Issue metadata
Sign in to add a comment
|
Regression: Window Frame Shadow Not Drawn in Panels (Hangouts)
Reported by
rk...@etouch.net,
Jul 27 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2809.0 Revision 12fd360cfa20b6ca7784225e58bf10647b721002-refs/heads/master@{#408012}(32/64 bit) OS: Windows 10 URL: https://chrome.google.com/webstore/detail/google-hangouts/nckgahadagoaajjgafhacjanaoiihapd/related?hl=en What steps will reproduce the problem? (1) Launch chrome,navigate to above url and click on 'ADD TO CHROME' button. (2) Click on Hangout extension icon, then click on 'Collapse' icon again click on extension icon. (3) Observe the boarder of extension window. Actual: Boarder of 'Hangouts' extension window is not visible properly after step 2. Expected: Boarder of 'Hangouts' extension window should seen properly. This is a regression issue, broken in 'M-54', below is bisect info: Good Build: 54.0.2805.0 Bad Build: 54.0.2809.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/f7789f833aa26bc38fe4a74276b0a57c45ca3c65..48e079d573d6385fab6ad7110475a2b9da913bab?pretty=fuller&n=100 Suspecting: r407508 Note: issue is not seen on windows 7, Mac and Linux OS.
,
Jul 27 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Aug 8 2016
Just to update: Issue is reproducible on windows 10 with latest build 54.0.2823.0
,
Aug 12 2016
Issue still persists on Win 10 using 54.0.2827.0. robliao@ : Could you please take a look into this.
,
Aug 12 2016
,
Aug 12 2016
The Window Frame Border is actually drawn by the system. With --disable-per-monitor-dpi and window frame shadows disabled in Windows, the resulting frame is just like the one in the regression. The question now becomes why the frame isn't getting a shadow. There is no actual border on the frame already.
,
Aug 12 2016
Looks like this is related to the EnableChildWindowDpiMessage call we make to handle DPI scaling of the non-client area.
,
Aug 12 2016
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfbe823c6a53aa85966ca3b7c8c5a4f08be609c9 commit bfbe823c6a53aa85966ca3b7c8c5a4f08be609c9 Author: robliao <robliao@chromium.org> Date: Fri Aug 12 23:37:24 2016 Only Call EnableChildWindowDpiMessage When Window Has A Frame Panels do not use the system frame. The "frame" is a shadow drawn by DWM. When EnableChildWindowDpiMessage is used on these windows, the shadow can occasiaonlly disappear when the window is moved. BUG= 631963 Review-Url: https://codereview.chromium.org/2246643002 Cr-Commit-Position: refs/heads/master@{#411819} [modify] https://crrev.com/bfbe823c6a53aa85966ca3b7c8c5a4f08be609c9/ui/gfx/win/window_impl.cc [modify] https://crrev.com/bfbe823c6a53aa85966ca3b7c8c5a4f08be609c9/ui/views/win/hwnd_message_handler.cc
,
Aug 15 2016
Looks fixed in Canary 54.0.2829.0
,
Aug 16 2016
Tested the issue on Latest Chrome Dev# 54.0.2830.0 on Windows and is working as intended. Hence adding TE-Verified Labels. Thank You. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rk...@etouch.net
, Jul 27 2016