New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631960 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rename wayland interfaces in src/third_party/wayland-protocols/unstable/

Project Member Reported by reve...@chromium.org, Jul 27 2016

Issue description

Change prefix for these interfaces from zwp to cr to avoid potential naming collisions with upstream interfaces.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 27 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e7e74a1cad9389829f7dcfef1860f80df2bc42

commit 33e7e74a1cad9389829f7dcfef1860f80df2bc42
Author: reveman <reveman@chromium.org>
Date: Sun Sep 18 10:31:00 2016

third_party: Update wayland-protocols to 1.7.

BUG= 631960 , 648028 
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2350593002
Cr-Commit-Position: refs/heads/master@{#419397}

[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/DEPS
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/README.chromium
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-client-protocol.h
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-server-protocol.h
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/include/protocol/stylus-unstable-v1-client-protocol.h
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/include/protocol/stylus-unstable-v1-server-protocol.h
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/protocol/gaming-input-protocol.c
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/protocol/stylus-protocol.c
[modify] https://crrev.com/33e7e74a1cad9389829f7dcfef1860f80df2bc42/third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef576bfe8a8feee1b27213e301907758c7bcd0c8

commit ef576bfe8a8feee1b27213e301907758c7bcd0c8
Author: reveman <reveman@chromium.org>
Date: Mon Sep 19 07:59:14 2016

third_party: Switch to zcr prefix for downstream wayland interfaces.

Add existing interfaces with zcr prefix and mark old zwp interfaces
as deprecated.

No change in behavior.

BUG= 631960 
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2350633002
Cr-Commit-Position: refs/heads/master@{#419417}

[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/components/exo/wayland/server.cc
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-client-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-server-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-client-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-server-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-client-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-server-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/stylus-unstable-v1-client-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/stylus-unstable-v1-server-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-client-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-server-protocol.h
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/protocol/alpha-compositing-protocol.c
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/protocol/gaming-input-protocol.c
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/protocol/secure-output-protocol.c
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/protocol/stylus-protocol.c
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/protocol/vsync-feedback-protocol.c
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/unstable/alpha-compositing/alpha-compositing-unstable-v1.xml
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/unstable/secure-output/secure-output-unstable-v1.xml
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
[modify] https://crrev.com/ef576bfe8a8feee1b27213e301907758c7bcd0c8/third_party/wayland-protocols/unstable/vsync-feedback/vsync-feedback-unstable-v1.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5355f6ebec7bc7a3fe53e5d9b5c891d780f27746

commit 5355f6ebec7bc7a3fe53e5d9b5c891d780f27746
Author: reveman <reveman@chromium.org>
Date: Mon Sep 19 12:44:01 2016

exo: Fix remote shell version typo.

Fix remote shell version typo causing ARC++ to break
as a result of the deprecated zwp interface being bound
with the wrong version number.

BUG= 631960 
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2348253002
Cr-Commit-Position: refs/heads/master@{#419439}

[modify] https://crrev.com/5355f6ebec7bc7a3fe53e5d9b5c891d780f27746/components/exo/wayland/server.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509a36315f6fb73ef0d93c1dff1eb78180ef74c4

commit 509a36315f6fb73ef0d93c1dff1eb78180ef74c4
Author: reveman <reveman@chromium.org>
Date: Mon Sep 19 13:30:44 2016

exo: Fix zwp ctor typos.

Causing crashes as it makes us create objects of incorrect
type.

BUG= 631960 
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2352663002
Cr-Commit-Position: refs/heads/master@{#419443}

[modify] https://crrev.com/509a36315f6fb73ef0d93c1dff1eb78180ef74c4/components/exo/wayland/server.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f983c68c3c9437d0f355ed7980dcbc428d50d1

commit c5f983c68c3c9437d0f355ed7980dcbc428d50d1
Author: reveman <reveman@chromium.org>
Date: Fri Sep 23 11:34:33 2016

third_party: Remove deprecated zwp wayland interfaces.

No change in behavior.

BUG= 631960 
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2352563002
Cr-Commit-Position: refs/heads/master@{#420597}

[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/components/exo/wayland/server.cc
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-client-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/alpha-compositing-unstable-v1-server-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-client-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/gaming-input-unstable-v1-server-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-client-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/secure-output-unstable-v1-server-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/stylus-unstable-v1-client-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/stylus-unstable-v1-server-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-client-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/include/protocol/vsync-feedback-unstable-v1-server-protocol.h
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/protocol/alpha-compositing-protocol.c
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/protocol/gaming-input-protocol.c
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/protocol/secure-output-protocol.c
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/protocol/stylus-protocol.c
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/protocol/vsync-feedback-protocol.c
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/unstable/alpha-compositing/alpha-compositing-unstable-v1.xml
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/unstable/gaming-input/gaming-input-unstable-v1.xml
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/unstable/secure-output/secure-output-unstable-v1.xml
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
[modify] https://crrev.com/c5f983c68c3c9437d0f355ed7980dcbc428d50d1/third_party/wayland-protocols/unstable/vsync-feedback/vsync-feedback-unstable-v1.xml

Status: Fixed (was: Assigned)

Sign in to add a comment