Renderer shouldn't sent unnecessary AutofillHostMsg_PasswordFormsParsed |
||
Issue descriptionWhat steps will reproduce the problem? (1) Load simple html with some forms like test password_form.html (2) Wait for the page loaded event (3) Drop all the PasswordFormManager instances What is the expected output? They aren't recreated. What do you see instead? They are resurrected because the renderer sends AutofillHostMsg_PasswordFormsParsed like if they were dynamically parsed. The reason for this is Document::didAssociateFormControl implementation. It sets the timer during parsing. 0.3 seconds later AutofillAgent::didAssociateFormControls is called. It may happen after the page was loaded. As the result all the forms are reloaded and sent again.
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/620ba75d0ad297a1a9ddfc6a35330c4128122fa6 commit 620ba75d0ad297a1a9ddfc6a35330c4128122fa6 Author: vasilii <vasilii@chromium.org> Date: Thu Aug 04 10:07:07 2016 Get rid of the timeouts in CredentialManagerBrowserTest.* After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile(). BUG= 631958 Review-Url: https://codereview.chromium.org/2210503002 Cr-Commit-Position: refs/heads/master@{#409754} [modify] https://crrev.com/620ba75d0ad297a1a9ddfc6a35330c4128122fa6/chrome/browser/password_manager/credential_manager_browsertest.cc
,
Nov 29
|
||
►
Sign in to add a comment |
||
Comment 1 by vasi...@chromium.org
, Aug 1 2016