New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631957 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Copying / moving files to a drive with unrecognized partitions finishes successfully without actually writing files

Project Member Reported by yamaguchi@chromium.org, Jul 27 2016

Issue description

Chrome OS Version: 54.0.2806.0

Steps To Reproduce:
(1) Connect an external, unformatted disk. (e.g. a USB drive with all partitions removed)
(2) Open Files app. See the media appears as "USB Drive" on the left pane.
(3) Drag and drop files from Google Drive or Downloads folder to "USB Drive" while pressing a [shift] key. (file move operation)
   [WARNING: this operation may delete the files]

Expected Result:
- Files are not written to the USB drive. (because it's not writable)
- The files stays in the original directory.
- An error message pops up.

Actual Result:
- Files are not written to the USB drive.
- The files in the original place are deleted.
- No error messages pop up.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always.

What is the impact to the user, and is there a workaround? If so, what is
it?
Users may unintentionally delete files when attempting to move them to a USB drive.

Please provide any additional information below. Attach a screen shot or
log if possible.

This is also reproducible by using ctrl-x + ctrl-v. In this case, ctrl-v should be pressed right after clicking "USB Drive" in the left pane of Files app. You cannot paste files after clicking the right pane.

The same issue happens when copying files instead of moving except that the original files are retained.
 
Labels: M-54
Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)
#CBC-RS/TC-watchlist

Labels: -M-54 M-55
Summary: Copying / moving files to unrecognized drive finishes successfully without actually writing files (was: Copying / moving files to unformatted drive finishes successfully without actually writing files)
Summary: Copying / moving files to a drive with unrecognized partitions finishes successfully without actually writing files (was: Copying / moving files to unrecognized drive finishes successfully without actually writing files)

Comment 6 by fukino@chromium.org, Sep 30 2016

Labels: -M-55 M-56
Labels: -M-56 M-57
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40415e909045db52fddee4c425f82a556aaa3317

commit 40415e909045db52fddee4c425f82a556aaa3317
Author: yamaguchi <yamaguchi@chromium.org>
Date: Tue Dec 06 10:24:01 2016

Disallow dropping or pasting files to a volume with unrecognized partition.

BUG= 631957 
TEST=manual test as noted in the bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2548363004
Cr-Commit-Position: refs/heads/master@{#436560}

[modify] https://crrev.com/40415e909045db52fddee4c425f82a556aaa3317/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment