New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631956 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-regression: Weird overlapping of windows is seen in overview mode

Project Member Reported by sc00335...@techmahindra.com, Jul 27 2016

Issue description

Version:54.0.2806.0/8639.0.0 (Official Build) dev-channel falco,gnawty,spring
OS: Chrome OS

What steps will reproduce the problem?
(1) Make sure you have some windows opened >> Hit search button from keyboard >> Hit Overview mode button >> Enter fullscreen >> Now exit fullscreen from keyboard and observe

Expected: No such overlapping should be seen on exiting fullscreen.
Actual: Instead Overview mode windows overlaps on main window.

Raising this as Non-regression issue as same behavior is seen in 47.0.2526.106/7520.63.0 stable channel daisy.

@varkha: Please confirm the behavior or help in re-assigning if it is not related to your change.
 
Actual_overlapping.webm
1.5 MB View Download
Screenshot 2016-07-27 at 16.03.26.png
635 KB View Download
Able to reproduce the issue on Gnawty using chrome version 54.0.2806.0/8639.0.0.

Comment 2 by varkha@chromium.org, Jul 27 2016

Thanks for filing this. Is this device dependent? I could not repro this on samus. Can a complete key press by key press repro steps be posted (including which windows are opened, in what order, what keys or gestures are used to enter and exit overview mode, etc.).
As per Comment#2: In 54.0.2806.0/8639.0.0 checked on falco,gnawty,spring.

Now re-checked on daisy,blaze,peppy of 54.0.2809.0/8644.0.0.

Checked the issue only by hitting keys from keyboard. Didn't use any gestures.

1.Make sure you have some windows opened[Opened Normal chrome window,Incognito window,files app[Any windows are fine- repros with any window opened]
2.Hit search button from keyboard [search icon on keyboard below tab key]
3.Hit Overview mode button [F5 or []]] ]
4.Enter fullscreen [F4 or [] ]
5.Now exit fullscreen from keyboard and observe[F4 or [] ]

Comment 4 by varkha@chromium.org, Jul 28 2016

Labels: -Pri-2 Pri-3
Yes, I got it now, thanks (the key is to enter and then exit immersive fullscreen while still in overview). This should be possible to fix by ignoring the window state accelerators such as F4 or Alt-+ (which causes a similar effect) while in overview mode. Also having the launcher being focused when entering overview is a key, it is probably controlling where the focus goes upon entering the overview and this is what causes the shortcuts to get processed (normally they are all ignored in overview mode). I'll drop the priority as it seems to have always existed and requires a non-trivial effort to reproduce.
Status: Started (was: Assigned)
Draft at https://codereview.chromium.org/2225683008/.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/738eca8c2bf6f6c0646408d9b970d5da83b53ba3

commit 738eca8c2bf6f6c0646408d9b970d5da83b53ba3
Author: varkha <varkha@chromium.org>
Date: Wed Aug 10 16:12:54 2016

[ash-md] Cancels app-list (launcher) before entering overview

This change proactively dismisses the app-list (launcher) when
overview mode is about to start. This prevents one of the top
level windows from being activated and disables accelerators that
target an active window while in overview mode.

BUG= 631956 
TEST=WindowSelectorTest.TextFilterActive

Review-Url: https://codereview.chromium.org/2225683008
Cr-Commit-Position: refs/heads/master@{#411049}

[modify] https://crrev.com/738eca8c2bf6f6c0646408d9b970d5da83b53ba3/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/738eca8c2bf6f6c0646408d9b970d5da83b53ba3/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/738eca8c2bf6f6c0646408d9b970d5da83b53ba3/ash/wm/overview/window_selector_unittest.cc

Comment 7 by varkha@chromium.org, Aug 10 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 54.0.2840.42

Sign in to add a comment