negativetextureapi.html failed on Mac |
||||||
Issue description
Run WebGL deqp test case negativetextureapi.html on Mac OS. It fails.
The root cause is that the underlying HW doesn't do full validation for invalid parameters for CopyTexSubImage3D. For instance, if level < 0 or level >= MaxLevel, it should generate INVALID_VALUE. However, the driver doesn't return appropriate GL error.
And the auto-gen code in Chromium command buffer for CopyTexSubImage3D doesn't do full validation too. So the test fails.
Besides, there are some other problems in the command buffer for CopyTex{Sub}Image{2D|3D} APIs. I want to improve these APIs step by step as below:
1) Add validation code for CopyTexSubImage3D to fix the bug for Mac.
2) Add more code to handle the out-of-bounds reading for CopyTexSubImage3D.
3) Do 1) and 2) for CopyTexImage3D in one step.
4) Remove duplicated code, unify all related APIs (CopyTex{Sub}Image{2D|3D}).
Suggestions are welcome.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4771076dd784de40192c7249914a2fbb208e7a49 commit 4771076dd784de40192c7249914a2fbb208e7a49 Author: yunchao.he <yunchao.he@intel.com> Date: Thu Jul 28 02:16:15 2016 WebGL 2: Fix bugs in negativetextureapi.html for Mac BUG= 631934 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2182443003 Cr-Commit-Position: refs/heads/master@{#408313} [modify] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h [modify] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h [modify] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b29cee86b63c0d22a3f80cfa151895b840ec94c7 commit b29cee86b63c0d22a3f80cfa151895b840ec94c7 Author: yunchao.he <yunchao.he@intel.com> Date: Fri Jul 29 10:14:21 2016 Command buffer: feedback loop detection for CopyTexSubImage3D BUG= 631934 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2190543005 Cr-Commit-Position: refs/heads/master@{#408611} [modify] https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7/gpu/command_buffer/service/framebuffer_manager.cc [modify] https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7/gpu/command_buffer/service/framebuffer_manager.h [modify] https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/b29cee86b63c0d22a3f80cfa151895b840ec94c7/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/363390aea0ce77347652905cf56d07be5c84cd6b commit 363390aea0ce77347652905cf56d07be5c84cd6b Author: cwallez <cwallez@chromium.org> Date: Mon Aug 01 16:15:09 2016 WebGL2 test expectations: add back suppression for Linux AMD It was removed in 4771076dd784de4 but wasn't completely fixed. TBR=zmo@chromium.org BUG= 631934 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2198053002 Cr-Commit-Position: refs/heads/master@{#408974} [modify] https://crrev.com/363390aea0ce77347652905cf56d07be5c84cd6b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Aug 9 2016
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67f2490eb77b5dfd78d6fa6aff3aed1e6e786ac5 commit 67f2490eb77b5dfd78d6fa6aff3aed1e6e786ac5 Author: yunchao.he <yunchao.he@intel.com> Date: Wed Aug 10 17:04:27 2016 Roll WebGL a7fa4b5..3020b31 and update webgl expectation https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a7fa4b5..3020b31 BUG= 631934 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2235673002 Cr-Commit-Position: refs/heads/master@{#411061} [modify] https://crrev.com/67f2490eb77b5dfd78d6fa6aff3aed1e6e786ac5/DEPS [modify] https://crrev.com/67f2490eb77b5dfd78d6fa6aff3aed1e6e786ac5/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Aug 11 2016
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3972370575795597962787da7449243bd1d5d57b commit 3972370575795597962787da7449243bd1d5d57b Author: yunchao.he <yunchao.he@intel.com> Date: Thu Aug 11 07:32:02 2016 Command buffer: CopyTexSubImage3D should clear the 3D texture if it is uncleared BUG= 631934 , 636626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2232743002 Cr-Commit-Position: refs/heads/master@{#411283} [modify] https://crrev.com/3972370575795597962787da7449243bd1d5d57b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/3972370575795597962787da7449243bd1d5d57b/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/3972370575795597962787da7449243bd1d5d57b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
,
Aug 11 2016
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f4547bc67a3ef3cb41208606885fb236e964f7b commit 4f4547bc67a3ef3cb41208606885fb236e964f7b Author: yunchao.he <yunchao.he@intel.com> Date: Tue Aug 16 17:23:25 2016 [Command buffer] CopyTexSubImage3D: Copying pixels outside of framebuffer should be untouched BUG= 636987 , 631934 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2234923002 Cr-Commit-Position: refs/heads/master@{#412271} [modify] https://crrev.com/4f4547bc67a3ef3cb41208606885fb236e964f7b/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Aug 17 2016
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0876d0ee62855de3a9329f9a758725130b1a2ae8 commit 0876d0ee62855de3a9329f9a758725130b1a2ae8 Author: yunchao.he <yunchao.he@intel.com> Date: Wed Aug 24 12:08:58 2016 [Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core profile BUG= 631934 , 638470 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2241593003 Cr-Commit-Position: refs/heads/master@{#414052} [modify] https://crrev.com/0876d0ee62855de3a9329f9a758725130b1a2ae8/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc [modify] https://crrev.com/0876d0ee62855de3a9329f9a758725130b1a2ae8/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h [modify] https://crrev.com/0876d0ee62855de3a9329f9a758725130b1a2ae8/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Sep 13 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kbr@chromium.org
, Jul 27 2016