In order to prevent regressions, it would be good to add a WebRTC browser_test that uses Opus Dtx.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9df939bf67e2dea8e3ca1d9a0857272324611b8 commit e9df939bf67e2dea8e3ca1d9a0857272324611b8 Author: ivoc <ivoc@chromium.org> Date: Sat Jul 30 00:50:41 2016 Adds a WebRTC browser_test with opus dtx enabled. Additionally, starts tracking the 'packetsSentPerSecond' metric for WebRTC browser_tests. BUG= 631927 Review-Url: https://codereview.chromium.org/2190533002 Cr-Commit-Position: refs/heads/master@{#408825} [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/media/webrtc_browsertest.cc [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/media/webrtc_browsertest_base.cc [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/media/webrtc_browsertest_base.h [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/media/webrtc_browsertest_perf.cc [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/media/webrtc_perf_browsertest.cc [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/browser/media/webrtc_video_quality_browsertest.cc [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/test/data/webrtc/munge_sdp.js [modify] https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8/chrome/test/data/webrtc/peerconnection.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dc179b22f88b81c6a083670bb09f22108420a4e commit 0dc179b22f88b81c6a083670bb09f22108420a4e Author: guidou <guidou@chromium.org> Date: Mon Aug 01 10:32:19 2016 Revert of Adds a WebRTC browser_test with opus dtx enabled. (patchset #5 id:100001 of https://codereview.chromium.org/2190533002/ ) Reason for revert: Speculative revert due to this CL being suspect of breaking webrtc bots. See https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/19829 Sample error message: [32431:32431:0801/012147:INFO:CONSOLE(13)] "Returning Test failed: Error: getSdpDefaultCodec() failed: "'m=video' line missing from |sdp|." at failTest (http://127.0.0.1:47758/webrtc/test_functions.js:46:15) at failure (http://127.0.0.1:47758/webrtc/test_functions.js:56:9) at getSdpDefaultCodec (http://127.0.0.1:47758/webrtc/munge_sdp.js:108:5) at getSdpDefaultVideoCodec (http://127.0.0.1:47758/webrtc/munge_sdp.js:93:10) at verifyDefaultVideoCodec (http://127.0.0.1:47758/webrtc/peerconnection.js:174:27) at <anonymous>:1:51 to test.", source: http://127.0.0.1:47758/webrtc/test_functions.js (13) ../../chrome/browser/media/webrtc_browsertest_base.cc:361: Failure Original issue's description: > Adds a WebRTC browser_test with opus dtx enabled. > > Additionally, starts tracking the 'packetsSentPerSecond' metric for WebRTC browser_tests. > > BUG= 631927 > > Committed: https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8 > Cr-Commit-Position: refs/heads/master@{#408825} TBR=jochen@chromium.org,minyue@chromium.org,phoglund@chromium.org,ivoc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 631927 Review-Url: https://codereview.chromium.org/2195293002 Cr-Commit-Position: refs/heads/master@{#408937} [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/media/webrtc_browsertest.cc [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/media/webrtc_browsertest_base.cc [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/media/webrtc_browsertest_base.h [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/media/webrtc_browsertest_perf.cc [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/media/webrtc_perf_browsertest.cc [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/browser/media/webrtc_video_quality_browsertest.cc [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/test/data/webrtc/munge_sdp.js [modify] https://crrev.com/0dc179b22f88b81c6a083670bb09f22108420a4e/chrome/test/data/webrtc/peerconnection.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99f8ad91e581c2982086c34392d86ca333cf0849 commit 99f8ad91e581c2982086c34392d86ca333cf0849 Author: grunell <grunell@chromium.org> Date: Thu Aug 18 14:55:14 2016 Reland of "Adds a WebRTC browser_test with opus dtx enabled.". Original CL: https://codereview.chromium.org/2190533002/ Original commit: e9df939bf67e2dea8e3ca1d9a0857272324611b8 Revert CL: https://codereview.chromium.org/2195293002/ Revert commit: 0dc179b22f88b81c6a083670bb09f22108420a4e The crash in the WebRTC audio quality browser tests was caused by one misplaced line in the javascript code. BUG= 631927 TBR=phoglund@chromium.org,jochen@chromium.org,minyue@chromium.org patch from issue 2248093002 at patchset 20001 (http://crrev.com/2248093002#ps20001) Review-Url: https://codereview.chromium.org/2254133002 Cr-Commit-Position: refs/heads/master@{#412826} [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/media/webrtc_browsertest.cc [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/media/webrtc_browsertest_base.cc [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/media/webrtc_browsertest_base.h [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/media/webrtc_browsertest_perf.cc [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/media/webrtc_perf_browsertest.cc [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/browser/media/webrtc_video_quality_browsertest.cc [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/test/data/webrtc/munge_sdp.js [modify] https://crrev.com/99f8ad91e581c2982086c34392d86ca333cf0849/chrome/test/data/webrtc/peerconnection.js
Comment 1 by bugdroid1@chromium.org
, Jul 30 2016