The following revision refers to this bug:
https://chromium.googlesource.com/chromium/tools/build.git/+/c5770707665087d737ef6e738622a1bd7bc6609b
commit c5770707665087d737ef6e738622a1bd7bc6609b
Author: yyanagisawa <yyanagisawa@chromium.org>
Date: Fri Jul 29 00:56:47 2016
Remove dead code from compile.py.
Removed following code:
- code to set NO_NACL_GOMA in certain hosts.
Since GN become default build system for Windows, no need to set
option only used by gyp.
- manually disables burst mode on network failure.
Now we gathers compiler_proxy.INFO via cloudtail, we do not need
to disable the feature to check it does something bad or not.
- setting goma.key
We have already deprecated goma.key, no need to have that like this.
- setting '?win' for Windows.
goma_ctl.py does this job, we do not need to have the code here.
- options.compiler in ('goma', 'goma-clang') in goma_teardown.
The same check has been done in goma_setup, and it sets
options.goma_dir = None if goma is not used, no need to have
duplicated check.
- args option in get_target_build_dir
get_target_build_dir does not use args.
Minor fixes:
- mentioned about env modification in goma_setup function comment.
- like other options do, overwrite env if options.goma_hermetic is set.
- Fixed the explanation on why goma_ctl.py stop should be done.
BUG= 631920
Review-Url: https://codereview.chromium.org/2191483002
[modify] https://crrev.com/c5770707665087d737ef6e738622a1bd7bc6609b/scripts/slave/compile.py
Comment 1 by tikuta@chromium.org
, Jul 27 2016