New issue
Advanced search Search tips

Issue 631920 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Remove dead / meaningless code from compile.py

Project Member Reported by tikuta@chromium.org, Jul 27 2016

Issue description

Please let me assign yyanagisawa for this issue.
We discussed about dead/meaningless code in https://codereview.chromium.org/2178193003/

 

Comment 1 by tikuta@chromium.org, Jul 27 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/c5770707665087d737ef6e738622a1bd7bc6609b

commit c5770707665087d737ef6e738622a1bd7bc6609b
Author: yyanagisawa <yyanagisawa@chromium.org>
Date: Fri Jul 29 00:56:47 2016

Remove dead code from compile.py.

Removed following code:
- code to set NO_NACL_GOMA in certain hosts.
  Since GN become default build system for Windows, no need to set
  option only used by gyp.
- manually disables burst mode on network failure.
  Now we gathers compiler_proxy.INFO via cloudtail, we do not need
  to disable the feature to check it does something bad or not.
- setting goma.key
  We have already deprecated goma.key, no need to have that like this.
- setting '?win' for Windows.
  goma_ctl.py does this job, we do not need to have the code here.
- options.compiler in ('goma', 'goma-clang') in goma_teardown.
  The same check has been done in goma_setup, and it sets
  options.goma_dir = None if goma is not used, no need to have
  duplicated check.
- args option in get_target_build_dir
  get_target_build_dir does not use args.

Minor fixes:
- mentioned about env modification in goma_setup function comment.
- like other options do, overwrite env if options.goma_hermetic is set.
- Fixed the explanation on why goma_ctl.py stop should be done.

BUG= 631920 

Review-Url: https://codereview.chromium.org/2191483002

[modify] https://crrev.com/c5770707665087d737ef6e738622a1bd7bc6609b/scripts/slave/compile.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 29 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/0ad3de720c10903053199d94f7fc57758d0b1b3e

commit 0ad3de720c10903053199d94f7fc57758d0b1b3e
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jul 29 01:16:50 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d582ab5518c72b20fd4cceda52807a7d9e9a57a9 Remove build target before build. (yyanagisawa@chromium.org)
  https://crrev.com/c5770707665087d737ef6e738622a1bd7bc6609b Remove dead code from compile.py. (yyanagisawa@chromium.org)

R=yyanagisawa@chromium.org
BUG= 631920 ,439737

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2194783002

[modify] https://crrev.com/0ad3de720c10903053199d94f7fc57758d0b1b3e/infra/config/recipes.cfg

Status: Fixed (was: Assigned)
I think I have cleaned up compile.py.
Thank you for cleanup.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/c6d5023583562d95e3f309a86c97929490265cc2

commit c6d5023583562d95e3f309a86c97929490265cc2
Author: tikuta <tikuta@chromium.org>
Date: Tue Aug 09 07:14:46 2016

Remove --goma-enable-compiler-info-cache option from compile.py

* compiler-info-cache is enabled by default

BUG= 631920 

Review-Url: https://codereview.chromium.org/2218413004

[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/compile.py
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipe_modules/chromium/config.py
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux32_Goma_Canary__clobber_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary__clobber_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Precise_Goma_LinkTest.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__clobber_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg__clobber_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_clbr_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dbg_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangGoma.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinGoma.json
[modify] https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinGoma_dll_.json

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/282cf128bc687eec8cee46c0e95fd1701b62be9a

commit 282cf128bc687eec8cee46c0e95fd1701b62be9a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 09 07:31:01 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2 Remove --goma-enable-compiler-info-cache option from compile.py (tikuta@chromium.org)

R=tikuta@chromium.org
BUG= 631920 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2224023004

[modify] https://crrev.com/282cf128bc687eec8cee46c0e95fd1701b62be9a/infra/config/recipes.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3123525e65f37f13b79b29a7cdb5a4471aede9c8

commit 3123525e65f37f13b79b29a7cdb5a4471aede9c8
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 09 09:57:27 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/697fd2909e82e505a47f7f244d521e6190e85d91 Reland of Unified the code to upload goma-related information. (yyanagisawa@chromium.org)
  https://crrev.com/c6d5023583562d95e3f309a86c97929490265cc2 Remove --goma-enable-compiler-info-cache option from compile.py (tikuta@chromium.org)

R=tikuta@chromium.org,yyanagisawa@chromium.org
BUG= 631920 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2227893003
Cr-Commit-Position: refs/heads/master@{#410623}

[modify] https://crrev.com/3123525e65f37f13b79b29a7cdb5a4471aede9c8/infra/config/recipes.cfg

Sign in to add a comment