New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631918 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression: Incognito window minimizes immediately on opening from wrench menu when Chromevox is enabled

Project Member Reported by sc00335...@techmahindra.com, Jul 27 2016

Issue description

Version:54.0.2806.0/8639.0.0 (Official Build) dev-channel falco,gnawty
OS: Chrome OS

What steps will reproduce the problem?
(1) Enable Chromevox from Accessibility section of devtools >> Open Browser >> Now try opening Incognito window from wrench menu

Expected: Incognito window should not  minimize on opening.
Actual: Instead incognito window minimizes immediately on opening from wrench menu.

NOTE:
1. Issue is also seen on opening minimized Incognito window from shelf, It immediately minimizes.
2. Issue is not seen on opening Incognito window using ctrl+shift+n.

This is a regression issue as it is working fine in 49.0.2623.54/7834.38.0 beta channel daisy.

Issue is also seen in 52.0.2743.85/8350.60.0 (Official Build) beta-channel daisy.

 
Actual_incognito minimize.webm
2.0 MB View Download
Expected_incognito minimize.webm
2.0 MB View Download

Comment 1 by ajha@chromium.org, Jul 27 2016

Labels: ReleaseBlock-Stable
Status: Untriaged (was: Unconfirmed)
Reproducible on 54.0.2806.0/8639.0.0 dev-channel gnawty.

Marking this Stable blocker for M-54 so that this gets proper attention.
Owner: dtseng@chromium.org
Status: Assigned (was: Untriaged)
David, since this is marked as an M54 stable blocker, can you take a look? 
Labels: -ReleaseBlock-Stable M-55
Not an M54 blocker since not a new regression. That said, we could evaluate a merge if safe fix available in time

dtseng@, any update on the evaluation of this case?
 
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a99c7d3e7dc2ca71bbaa127099239355a41fd37

commit 7a99c7d3e7dc2ca71bbaa127099239355a41fd37
Author: dtseng <dtseng@chromium.org>
Date: Wed Oct 12 00:20:23 2016

Recovery: Implement focus recovery across root AutomationNodes

This cl maintains a WeakMap of AutomationRootNode objects to the last known node that had ChromeVox range.

This map gets updated manually when marked or implicitly when focus crosses top level root nodes.

TEST=manual; open context menu, open panel, activate menus that manipulate focus, press escape; ctrl+tab, alt+tab. Verify focus lands as expected.
BUG= 631918 , 628912 , 624586 , 605377 , 524673 , 652143 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412433004
Cr-Commit-Position: refs/heads/master@{#424612}

[modify] https://crrev.com/7a99c7d3e7dc2ca71bbaa127099239355a41fd37/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/7a99c7d3e7dc2ca71bbaa127099239355a41fd37/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/7a99c7d3e7dc2ca71bbaa127099239355a41fd37/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/7a99c7d3e7dc2ca71bbaa127099239355a41fd37/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js
[modify] https://crrev.com/7a99c7d3e7dc2ca71bbaa127099239355a41fd37/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Comment 5 by dtseng@chromium.org, Oct 12 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on ChromeOS 8920.0.0, 56.0.2897.0
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 12 2016

Labels: -Merge-TBD

Sign in to add a comment