New issue
Advanced search Search tips

Issue 631912 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Crash in CJBig2_Context::parseSymbolDict

Project Member Reported by ClusterFuzz, Jul 27 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6531738176323584

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000008
Crash State:
  CJBig2_Context::parseSymbolDict
  CJBig2_Context::ProcessingParseSegmentData
  CJBig2_Context::decode_SquentialOrgnazation
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=407480:407721

Minimized Testcase (989.11 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95fKopEM1q5ZMt1lhHo1fW8CTcbjQy3MykZdwMkFxhcape3fzUqfe8BTdtXA6k-Hb1Cheu27dncBTUjYf4tKlNmhvUrOQNjfhutd9snOBha6_T1cMmAA4LDjnyf3DVeToyOAEfrnPLhXXAtSN6B4L4oHIAdKwy5EjbaWf1aGPqmd8HK2zo?testcase_id=6531738176323584

Filer: rnimmagadda

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug M-54 Findit-for-crash Te-Logged Pri-2 Type-Bug-Security
Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
Suspecting:

Author: weili
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/0024a22b4a793630a1a8e8d85c4525c7b82a3ed7
Time: Sun Jul 24 08:26:49 2016 -0700
File JBig2_Context.cpp is changed in this cl (and is part of stack frame #2, "CJBig2_Context::parseSymbolDict"; frame #3, "CJBig2_Context::ProcessingParseSegmentData"; frame #4, "parseSegmentData"; frame #5, "CJBig2_Context::decode_SquentialOrgnazation"; frame #6, "decode_EmbedOrgnazation")
Minimum distance from crash line to modified line: 5. (file: JBig2_Context.cpp, crashed on: 589, modified: 594).

@weili: Could you please look into this issue.

Thank you.
Project Member

Comment 2 by ClusterFuzz, Jul 27 2016

Labels: Hotlist-SyzyASAN
Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5244617612328960

Fuzzer: ifratric_pdf_generic
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000003
Crash State:
  CJBig2_Context::parseSymbolDict
  CJBig2_Context::ProcessingParseSegmentData
  CJBig2_Context::parseSegmentData
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_chrome&range=407779:407803

Minimized Testcase (281.48 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95p2O78nScayqCMMcw9TrexqNC8uYvLTiHnDKe8znZGuScyZTzzYmV47bZuRMgymmfYuKkmiqq1o9SsKZgdQD_oG1NGAP3suL2J9Ebv3j50yF0Vt13YMMSI5f7eHe5RzyZ-lhfWz89-rjMClzWMy_sYGovi3gAPPtqgTANPsdwFeHrEQWo?testcase_id=5244617612328960

Filer: rnimmagadda

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

Comment 3 by och...@chromium.org, Jul 27 2016

Cc: thestig@chromium.org och...@chromium.org manoranjanr@google.com
Issue 632051 has been merged into this issue.
Cc: infe...@chromium.org
Labels: -Type-Bug-Security OS-Windows Type-Bug-Regression
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 27 2016

Labels: Fracas


If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 6 by rickyz@chromium.org, Jul 27 2016

The bug is here: https://codereview.chromium.org/2178613002/diff/20001/core/fxcodec/codec/fx_codec_jbig.cpp#newcode23

if (!pContextHolder->get())

was changed to

if (!pContextHolder)

where pContextHolder is a std::unique_ptr<JBig2_DocumentContext>* pContextHolder. As a result, the case that populates pContextHolder is never executed.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 27 2016

Labels: FoundIn-M-54
Users experienced this crash on the following builds:

Win Canary 54.0.2809.0 -  6.85 CPM, 77 reports, 26 clients (signature CJBig2_Context::parseSymbolDict)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Status: Fixed (was: Assigned)
Will roll DEPS shortly.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 2 2016

Components: Internals>Plugins>PDF
Project Member

Comment 12 by ClusterFuzz, Aug 4 2016

ClusterFuzz has detected this issue as fixed in range 409223:409458.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6531738176323584

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000008
Crash State:
  CJBig2_Context::parseSymbolDict
  CJBig2_Context::ProcessingParseSegmentData
  CJBig2_Context::decode_SquentialOrgnazation
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=407480:407721
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=409223:409458

Minimized Testcase (989.11 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95fKopEM1q5ZMt1lhHo1fW8CTcbjQy3MykZdwMkFxhcape3fzUqfe8BTdtXA6k-Hb1Cheu27dncBTUjYf4tKlNmhvUrOQNjfhutd9snOBha6_T1cMmAA4LDjnyf3DVeToyOAEfrnPLhXXAtSN6B4L4oHIAdKwy5EjbaWf1aGPqmd8HK2zo?testcase_id=6531738176323584

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Cc: pucchakayala@google.com jam@chromium.org tsepez@chromium.org
Issue 634526 has been merged into this issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment