Issue metadata
Sign in to add a comment
|
Regression: Chromevox toolbar overlaps with overview mode search box |
||||||||||||||||||||||||
Issue descriptionVersion:54.0.2806.0/8639.0.0 (Official Build) dev-channel falco,spring,gnawty OS: Chrome OS What steps will reproduce the problem? (1) Enable Chromevox from Accessibility section of settings so that chromevox toolbar is seen >> Open any window >> Switch to overview mode >> Hit any letter from keyboard and observe searchbox of overview mode Expected: Chromevox toolbar should not hide overview mode search box. Actual: Instead searchbox is half hidden under chromevox toolbar. This is a regression issue as same is working fine in 52.0.2743.85/8350.60.0 (Official Build) beta-channel daisy. @varkha: Please confirm the behavior.
,
Jul 27 2016
+sgabriel@, How do you want to unoverlap in this case? Move down the search box? Always or only when Chromevox bar is visible?
,
Jul 27 2016
Move down only when chromevox seems the way to go.
,
Aug 2 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da81a26c1a9726d08b01db32a9f33b9d007d6cac commit da81a26c1a9726d08b01db32a9f33b9d007d6cac Author: varkha <varkha@chromium.org> Date: Wed Aug 03 01:48:05 2016 [ash-md] Fixes the vertical offset for search in overview with ChromeVox BUG= 631908 Review-Url: https://codereview.chromium.org/2208513002 Cr-Commit-Position: refs/heads/master@{#409423} [modify] https://crrev.com/da81a26c1a9726d08b01db32a9f33b9d007d6cac/ash/common/wm/overview/window_selector.cc
,
Aug 3 2016
,
Aug 3 2016
The fix in #5 treats ChromeVox panel as any fixed opaque element on screen - it changes the available work area and so positioning of all overview mode elements is affected when ChromeVox panel is visible and not just the search box.
,
Aug 5 2016
verified on 54.0.2819.0/8676.0.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Jul 27 2016Labels: ReleaseBlock-Stable