New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631875 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Check spec compliance of serialization of timing functions

Project Member Reported by suzyh@chromium.org, Jul 27 2016

Issue description

The serialization of timing functions has been specced: https://drafts.csswg.org/css-transitions/#serializing-a-timing-function

We need to check whether we're compliant with this spec and make any changes if not.
 
Owner: suzyh@chromium.org

Comment 2 by suzyh@chromium.org, Sep 13 2016

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d660b195483e9910ee6bfc3ad25df28301a35259

commit d660b195483e9910ee6bfc3ad25df28301a35259
Author: suzyh <suzyh@chromium.org>
Date: Wed Sep 14 22:44:53 2016

Fix serialization of step timing functions

The CSS Transitions specification recently added a section specifying how timing
functions should be serialized:
https://hg.csswg.org/drafts/rev/12d32649a91f
https://drafts.csswg.org/css-transitions/#serializing-a-timing-function

This patch changes how step timing functions are serialized in order to bring it
in line with the spec. The corresponding parsing function devtools/front_end is
also updated.

The removal of "step-middle" and "steps(x, middle)" as valid values is deferred
until frames() is implemented (see crbug.com/646265).

BUG= 631875 , 600248 

Review-Url: https://codereview.chromium.org/2330283004
Cr-Commit-Position: refs/heads/master@{#418704}

[delete] https://crrev.com/2eacf266f015eca06c70449f397d973bad57ae68/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt
[modify] https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html
[modify] https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259/third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp
[modify] https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[modify] https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
[modify] https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259/third_party/WebKit/Source/platform/animation/TimingFunction.cpp
[modify] https://crrev.com/d660b195483e9910ee6bfc3ad25df28301a35259/third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp

Comment 4 by suzyh@chromium.org, Sep 14 2016

Status: Fixed (was: Started)
Done, except for the removal of step-middle, which is covered by issue 646265.

Sign in to add a comment