New issue
Advanced search Search tips

Issue 631849 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 513516



Sign in to add a comment

Add more counters for -webkit-appearance:button and textfield

Project Member Reported by tkent@chromium.org, Jul 26 2016

Issue description

Usage of -webkit-appearance:button and -webkit-appearance:textfield is high.

https://www.chromestatus.com/metrics/feature/timeline/popularity/1354
https://www.chromestatus.com/metrics/feature/timeline/popularity/1362

We'd like to count
 button for elements with button appearance by default
 button for <a>
 textfield for elements with textfield appearance by default
 textfield for <input type=search>

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b592f6c3a2c7a8caa92412b72192ddacee01341

commit 7b592f6c3a2c7a8caa92412b72192ddacee01341
Author: tkent <tkent@chromium.org>
Date: Wed Jul 27 03:25:50 2016

Add more UseCounters for -webkit-appearance:button and -webkit-appearance:textfield.

We found
 - |button| and |textfield| were frequently used in 'CSS reset'
 - there were some instances of <a> with -webkit-appearance:button

We'd like to know how frequently they affect actual rendering.

This CL adds the following counters:
 * -webkit-appearance:button is actually rendered
 * -webkit-appearance:button for elements with button appearance by default
 * -webkit-appearance:button for <a>
 * -webkit-appearance:button for element with push-button appearance by default
 * -webkit-appearance:textfield is actually rendered
 * -webkit-appearance:textfield for elements with textfield appearance by default
 * -webkit-appearance:textfield for <input type=search>

BUG= 631849 

Review-Url: https://codereview.chromium.org/2177283008
Cr-Commit-Position: refs/heads/master@{#408033}

[modify] https://crrev.com/7b592f6c3a2c7a8caa92412b72192ddacee01341/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/7b592f6c3a2c7a8caa92412b72192ddacee01341/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/7b592f6c3a2c7a8caa92412b72192ddacee01341/tools/metrics/histograms/histograms.xml

Comment 2 by tkent@chromium.org, Jul 27 2016

Labels: Merge-Request-53 M-53
Status: Fixed (was: Started)

Comment 3 by dimu@chromium.org, Jul 28 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f262617ee9532463277cac7a39d4b30af6b164e1

commit f262617ee9532463277cac7a39d4b30af6b164e1
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jul 28 04:16:57 2016

Merge "Add more UseCounters for -webkit-appearance:button and -webkit-appearance:textfield." to M53.

We found
 - |button| and |textfield| were frequently used in 'CSS reset'
 - there were some instances of <a> with -webkit-appearance:button

We'd like to know how frequently they affect actual rendering.

This CL adds the following counters:
 * -webkit-appearance:button is actually rendered
 * -webkit-appearance:button for elements with button appearance by default
 * -webkit-appearance:button for <a>
 * -webkit-appearance:button for element with push-button appearance by default
 * -webkit-appearance:textfield is actually rendered
 * -webkit-appearance:textfield for elements with textfield appearance by default
 * -webkit-appearance:textfield for <input type=search>

BUG= 631849 

Review-Url: https://codereview.chromium.org/2177283008
Cr-Commit-Position: refs/heads/master@{#408033}
(cherry picked from commit 7b592f6c3a2c7a8caa92412b72192ddacee01341)

Review URL: https://codereview.chromium.org/2182413005 .

Cr-Commit-Position: refs/branch-heads/2785@{#384}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/f262617ee9532463277cac7a39d4b30af6b164e1/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/f262617ee9532463277cac7a39d4b30af6b164e1/third_party/WebKit/Source/core/paint/ThemePainter.cpp
[modify] https://crrev.com/f262617ee9532463277cac7a39d4b30af6b164e1/tools/metrics/histograms/histograms.xml

Sign in to add a comment