New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631848 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Separate DPTF logic from existing thermal logic.

Project Member Reported by ravisadineni@chromium.org, Jul 26 2016

Issue description

OS: Chromium os

Currently both DPTF and EC thermal logic to throttle AP or control fans is taken care by thermal_control hook in thermal.c. Due to this we define thermal_params to default values even in the boards where thermal logic is completely taken care by DPTF.

struct ec_thermal_config thermal_params[] = {
	/* {Twarn, Thigh, Thalt}, fan_off, fan_max */
	/* FIXME(dhendrix): Implement this... */
	{{0, 0, 0}, 0, 0},	/* Battery */
	{{0, 0, 0}, 0, 0},	/* Ambient */
	{{0, 0, 0}, 0, 0},	/* Charger */
};

Separating the DPTF logic so that we don't have to define thermal_params in boards where thermal control is completely taken care by DPTF.  
 
Cc: rspangler@chromium.org dhend...@chromium.org tbroch@google.com dlaurie@chromium.org
Components: OS>Firmware>EC
Labels: OS-Chrome
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/bcb0de22a429eacb2e3f588cd93294b9bccea2bc

commit bcb0de22a429eacb2e3f588cd93294b9bccea2bc
Author: Ravi Chandra Sadineni <ravisadineni@chromium.org>
Date: Wed Jul 27 01:04:09 2016

Use CONFIG_DPTF flag instead of THROTTLE_AP.

Signed-off-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>

BRANCH=none
BUG= chromium:631848 
TEST=make buildall -j
CQ-DEPEND=CL:363008

Change-Id: I3c35f5ab2e3a1537ac6e8c750171d5c2b3a6570f
Reviewed-on: https://chromium-review.googlesource.com/363583
Commit-Ready: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@google.com>

[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/strago/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/oak/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/elm/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/lucid/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/rambi/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/strago/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/rambi/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/elm/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/oak/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/wheatley/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/glados/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/amenia/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/wheatley/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/chell/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/chell/board.h
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/amenia/board.c
[modify] https://crrev.com/bcb0de22a429eacb2e3f588cd93294b9bccea2bc/board/glados/board.c

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment