New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631840 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Not on Chrome
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

MD History: "Cannot read property" errors on clicking 3-dot menu

Project Member Reported by michae...@chromium.org, Jul 26 2016

Issue description

Version: 54.0.2809.0
OS: Linux

Getting a lot of errors and sometimes the menu doesn't open.

0. Have history entries in MD History
1. Click a 3-dot menu
2. Close the 3-dot menu (e.g., click Esc)
3. Repeat 1 & 2 once or twice, either for the same menu, or for different menus

Every 2-3 times throws an error:

Uncaught TypeError: Cannot read property 'domain' of null (list_container.js:175)
Uncaught TypeError: Cannot read property 'url' of null (browser_service.js:32)

 
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
The menu is still clickable while it is (invisibly) animating out, which is what is causing this. I'll look into how paper-menu-button gets around this.
Status: ExternalDependency (was: Assigned)
I don't think it's possible to fix this without changing iron-dropdown, so I've filed an issue here: https://github.com/PolymerElements/iron-dropdown/issues/97.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e022b8b94971d07b93ed758b259a0ed31da9a015

commit e022b8b94971d07b93ed758b259a0ed31da9a015
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Aug 09 02:52:14 2016

MD WebUI: Simplify cr-shared-menu exit animation

The current menu exit animation has the menu fade out while shrinking
width and height. However, the shrinking is barely visible and causes
visual glitches when quickly closing/reopening the menu.

This change does not completely fix either of the linked bugs, but it
greatly lessens their effect.

BUG= 632251 , 631840 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2222013003
Cr-Commit-Position: refs/heads/master@{#410553}

[modify] https://crrev.com/e022b8b94971d07b93ed758b259a0ed31da9a015/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js

Labels: -Pri-1 Pri-2
Status: WontFix (was: ExternalDependency)
This bug is now obsolete since we don't use cr-action-menu or iron-dropdown anymore.

Sign in to add a comment