New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631833 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Log spam on launching latest Chrome Canary

Project Member Reported by erikc...@chromium.org, Jul 26 2016

Issue description

I get hundreds of the following message:

"""
dyld: warning, LC_RPATH @loader_path/../../../../../../.. in /Applications/Google Chrome Canary.app/Contents/Versions/54.0.2808.0/Google Chrome Helper.app/Contents/MacOS/Google Chrome Helper being ignored in restricted program because of @loader_path
d
"""
 

Comment 1 by rsesek@chromium.org, Jul 26 2016

What OS?
10.11.5

Comment 3 by rsesek@chromium.org, Jul 26 2016

Owner: rsesek@chromium.org
Status: Started (was: Untriaged)
Interesting, I'm not seeing that, but it's an easy fix.

Comment 4 by rsesek@chromium.org, Jul 26 2016

That's also the only LC_RPATH that we ship:

% find /Applications/Google\ Chrome\ Canary.app/Contents -type f -exec bash -c "file '{}' | grep Mach >/dev/null && otool -l '{}' | grep -C5 RPATH && echo '{}'" \;
         name /usr/lib/libSystem.B.dylib (offset 24)
   time stamp 2 Wed Dec 31 19:00:02 1969
      current version 1213.0.0
compatibility version 1.0.0
Load command 12
          cmd LC_RPATH
      cmdsize 48
         path @loader_path/../../../../../../.. (offset 12)
Load command 13
      cmd LC_FUNCTION_STARTS
  cmdsize 16
/Applications/Google Chrome Canary.app/Contents/Versions/54.0.2806.0/Google Chrome Helper.app/Contents/MacOS/Google Chrome Helper
         name /usr/lib/libSystem.B.dylib (offset 24)
   time stamp 2 Wed Dec 31 19:00:02 1969
      current version 1213.0.0
compatibility version 1.0.0
Load command 12
          cmd LC_RPATH
      cmdsize 48
         path @loader_path/../../../../../../.. (offset 12)
Load command 13
      cmd LC_FUNCTION_STARTS
  cmdsize 16
/Applications/Google Chrome Canary.app/Contents/Versions/54.0.2807.1/Google Chrome Helper.app/Contents/MacOS/Google Chrome Helper
         name /usr/lib/libSystem.B.dylib (offset 24)
   time stamp 2 Wed Dec 31 19:00:02 1969
      current version 1213.0.0
compatibility version 1.0.0
Load command 12
          cmd LC_RPATH
      cmdsize 48
         path @loader_path/../../../../../../.. (offset 12)
Load command 13
      cmd LC_FUNCTION_STARTS
  cmdsize 16
/Applications/Google Chrome Canary.app/Contents/Versions/54.0.2808.0/Google Chrome Helper.app/Contents/MacOS/Google Chrome Helper

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1905fc8c9e06650f75433a78e87e26477873da54

commit 1905fc8c9e06650f75433a78e87e26477873da54
Author: rsesek <rsesek@chromium.org>
Date: Wed Jul 27 00:30:00 2016

[Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build.

BUG= 631833 
R=erikchen@chromium.org

Review-Url: https://codereview.chromium.org/2183963003
Cr-Commit-Position: refs/heads/master@{#407988}

[modify] https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54/chrome/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95f93fb96fd66efe1a1ac330265124f84069ab78

commit 95f93fb96fd66efe1a1ac330265124f84069ab78
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jul 27 01:18:53 2016

Revert of [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. (patchset #1 id:1 of https://codereview.chromium.org/2183963003/ )

Reason for revert:
This is causing failures on Mac Build. See:

https://build.chromium.org/p/chromium/builders/Mac/builds/18011

Original issue's description:
> [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build.
>
> BUG= 631833 
> R=erikchen@chromium.org
>
> Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54
> Cr-Commit-Position: refs/heads/master@{#407988}

TBR=erikchen@chromium.org,dpranke@google.com,dpranke@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 631833 

Review-Url: https://codereview.chromium.org/2187753002
Cr-Commit-Position: refs/heads/master@{#408006}

[modify] https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78/chrome/BUILD.gn

Sample log output from the above failure:

Writing """\
enable_stripping = true
goma_dir = "/b/c/cipd/goma"
is_component_build = false
is_debug = false
use_goma = true
""" to /b/c/b/mac_ng/src/out/Release/args.gn.

/b/c/b/mac_ng/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:696:7: Undefined variable for +=.
      ldflags +=
      ^------
I don't have something with this name in scope now.
See //BUILD.gn:203:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4860c3320f6268f980e68cb73167f90acf10a8e7

commit 4860c3320f6268f980e68cb73167f90acf10a8e7
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Jul 27 14:53:49 2016

[Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build.

BUG= 631833 
R=dpranke@chromium.org, erikchen@chromium.org

Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54
Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78

Review URL: https://codereview.chromium.org/2183963003 .

Cr-Commit-Position: refs/heads/master@{#408126}

[modify] https://crrev.com/4860c3320f6268f980e68cb73167f90acf10a8e7/chrome/BUILD.gn

Comment 9 by rsesek@chromium.org, Jul 27 2016

Labels: Proj-GN-Migration-Ship
Status: Fixed (was: Started)
Erik: Please verify in tomorrow's canary, as I'm not seeing these messages.

Comment 11 by mark@chromium.org, Jul 27 2016

Robert was looking in Console.app, but these messages go to stderr. stderr doesn’t go to the system log (ASL, and therefore Console.app) since 10.8.

We’re both looking at stderr now and are seeing the messages, and whoa, boy, are there a lot of them! Canary 54.0.2809.0 for me.

Sign in to add a comment