New issue
Advanced search Search tips

Issue 631832 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 537368
issue 613355



Sign in to add a comment

Toolchain waterfall grouped builders are slaves to the wrong master

Project Member Reported by cmt...@chromium.org, Jul 26 2016

Issue description

The toolchain slave builders on the chromeos waterfall (gcc-toolchain-group, llvm-toolchain-group, and llvm-next-toolchain-group) are slave of internal_master rather than toolchain-master.

We need help fixing this, as the master-slave relationships cannot be explicitly defined anywhere.
 
Blocking: 613355
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0e3a27fcbb9de005f4d01418d8862502733661f9

commit 0e3a27fcbb9de005f4d01418d8862502733661f9
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jul 29 01:05:29 2016

TOOLCHAIN_TYPE: Update handling of toolchain builders.

* Move toolchain manifests into 'toolchain' sub-dir of
  manifest-versions.

* Switch toolcahin builders from ManifestVersionedSyncStage to
  MasterSlaveLKGMSyncStage, to stop incrementing release version.

THIS WILL BREAK TOOLCHAIN SLAVES until they start being triggered from
the toolchain sub-dir of manifest-versions.

BUG= chromium:631832 
TEST=cbuildbot/run_tests (which isn't a good test)

Change-Id: Ic0e51d1e592f10a80a1e781de18c8bc7a5a75e8f
Reviewed-on: https://chromium-review.googlesource.com/364320
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/0e3a27fcbb9de005f4d01418d8862502733661f9/cbuildbot/config_dump.json
[modify] https://crrev.com/0e3a27fcbb9de005f4d01418d8862502733661f9/cbuildbot/chromeos_config.py
[modify] https://crrev.com/0e3a27fcbb9de005f4d01418d8862502733661f9/cbuildbot/lkgm_manager.py
[modify] https://crrev.com/0e3a27fcbb9de005f4d01418d8862502733661f9/cbuildbot/builders/simple_builders.py

Status: Fixed (was: Started)
Blocking: 537368
Labels: VerifyIn-54

Comment 7 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 8 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment