New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631812 link

Starred by 3 users
Status: Fixed
Owner:
█ groby@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 0
Type: Bug-Regression



Sign in to add a comment

chrome:tracing crashes when "Record" button is clicked

Project Member Reported by charliea@chromium.org, Jul 26 2016 
Steps to reproduce: 

1) Sync to Chromium ToT (git pull, gclient sync)
2) Apply https://codereview.chromium.org/download/issue2187453002_1.diff to third_party/catapult. This is necessary because about:tracing was broken for another reason when this CL was submitted. This can be done with:

$ curl -0 https://codereview.chromium.org/download/issue2187453002_1.diff | git apply -3 -

3) Rebuild chrome 

$ ninja -C out/Default chrome

4) Open chrome and go to chrome:tracing
5) Click "Record" in the upper left corner
6) Click "Record" in the dialog

EXPECTED: Chrome starts recording a trace
ACTUAL: Chrome crashes

Comment 1 by charliea@chromium.org, Jul 26 2016 

Revert in commit queue now: https://codereview.chromium.org/2186493003/
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b3080b7cd46d29b61832af81e91146a5d00116b

commit 4b3080b7cd46d29b61832af81e91146a5d00116b
Author: charliea <charliea@chromium.org>
Date: Tue Jul 26 23:00:57 2016

Revert "[MD Settings] Remove jank for webui."

This reverts commit b6b53857a5ad6aecc8752bccb947147d101d8417.

This CL was causing about:tracing to crash when "Record was clicked"

TBR=groby@chromium.org,dbeam@chromium.org,mmenke@chromium.org
BUG= 631812 

Review-Url: https://codereview.chromium.org/2186493003
Cr-Commit-Position: refs/heads/master@{#407950}

[modify] https://crrev.com/4b3080b7cd46d29b61832af81e91146a5d00116b/content/browser/webui/url_data_manager_backend.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c428bad618519ab8c696f697a4208022c6d9b3

commit a6c428bad618519ab8c696f697a4208022c6d9b3
Author: nednguyen <nednguyen@google.com>
Date: Wed Jul 27 16:11:28 2016

[tools/perf] Add integration test for about://tracing UI

BUG= 631812 , 631535 , 630030 

Review-Url: https://codereview.chromium.org/2189603002
Cr-Commit-Position: refs/heads/master@{#408143}

[add] https://crrev.com/a6c428bad618519ab8c696f697a4208022c6d9b3/tools/perf/core/about_tracing_integration_test.py
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 10 2016 

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by charliea@chromium.org, Aug 10 2016

Status: Fixed (was: Assigned)
Forgot to mark this as fixed.
►

Sign in to add a comment