TextInputManager should consider the focused Render(Frame||Widget)HostImpl while tracking TextInputState |
|||||
Issue descriptionCurrently, the assumption behind TextInputState tracking in TextInputManager is that the IPC to set the TextInputState.type to non-NONE is always received from a RenderWidget which is already focused. This might not be true as a slow renderer might send TextInputState/Focus IPCs too late. We should make sure the TextInputManager::GetActiveWidget() is either null (when there is no focused <input>) or equal to the RenderWidgetHost of the focused frame. This will help us fix/avoid race conditions which might arise in pages with slow renderers.
,
Mar 10 2017
Raising the priority since this might become an issue down the road (see issue 699699 for context). We might need to still call content_view_core_->UpdateImeAdpater even when the current focused view has a TextInputState.type of ui::TEXT_INPUT_TYPE_NONE. So we should really care about focus rather than text input type. Other than that using the concept of focus the logic behind tracking and updating TextInputState becomes much simpler to follow.
,
Mar 10 2017
,
Nov 18 2017
ekaramad@: Is this still needed, and still a P1?
,
Mar 26 2018
Uh apologies for the delayed response. Not really. This is at best more of a refactoring which is not immediately necessary. I should bump it down to P3 actually.
,
Mar 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ekaramad@chromium.org
, Jul 27 2016