I'm breaking this effort up into multiple CLs, and it includes other little tidy/fix jobs.
https://codereview.chromium.org/2163803003/ [chrome_elf] Removing blacklist finch for dynamic dll changes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4da848392dabb7b49e554a15ad47d1c9f0dac78 commit c4da848392dabb7b49e554a15ad47d1c9f0dac78 Author: pennymac <pennymac@chromium.org> Date: Wed Jul 27 23:24:35 2016 [chrome_elf] Removing blacklist finch for dynamic dll changes. Part of chrome_elf cleanup. This was never used in the wild, and we won't need it in the foreseeable future. Leaving beacon and emergency disable finch switch for safety. Tests: 1) chrome_elf_unittests, chrome_elf_util_unittest.cc: BlacklistTest* 2) unit_tests, chrome_elf_init_unittest_win.cc: ChromeBlacklistTrialTest* R=robertshield@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng BUG= 631771 Review-Url: https://codereview.chromium.org/2163803003 Cr-Commit-Position: refs/heads/master@{#408269} [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome/browser/win/chrome_elf_init.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome/browser/win/chrome_elf_init.h [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome/browser/win/chrome_elf_init_unittest.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome_elf/blacklist/blacklist.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome_elf/blacklist/blacklist.h [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome_elf/blacklist/test/blacklist_test.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome_elf/blacklist/test/blacklist_test_main_dll.def [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome_elf/chrome_elf_constants.cc [modify] https://crrev.com/c4da848392dabb7b49e554a15ad47d1c9f0dac78/chrome_elf/chrome_elf_constants.h
https://codereview.chromium.org/2183263003/ [chrome_elf] Big cleanup and removing dependencies that recently crept in. PART 1.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58 commit d2767f8b41a8f7f70bddbd0783a8ef27a9370e58 Author: pennymac <pennymac@chromium.org> Date: Mon Aug 15 18:03:57 2016 [chrome_elf] Big cleanup and removing dependencies that recently crept in. PART 1. - Moving all crash related APIs into one place (and out of chrome_elf_main). - Started to clean up external dependencies - starting with hook_utils. - Removed dependency on base/win/iat_patch_function. BUG= 631771 Review-Url: https://codereview.chromium.org/2183263003 Cr-Commit-Position: refs/heads/master@{#411982} [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/BUILD.gn [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/blacklist.gypi [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/blacklist/blacklist.cc [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/blacklist/blacklist_interceptions.cc [delete] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/chrome_elf/blacklist/crashpad_helper.cc [delete] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/chrome_elf/blacklist/crashpad_helper.h [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/chrome_elf.gyp [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/chrome_elf_security.cc [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/chrome_elf_security.h [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/chrome_elf_util_unittest.cc [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/crash/crash_helper.cc [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/crash/crash_helper.h [modify] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/elf_imports_unittest.cc [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/hook_util/hook_util.cc [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/hook_util/hook_util.h [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/hook_util/test/hook_util_test.cc [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/hook_util/test/hook_util_test_dll.cc [add] https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58/chrome_elf/hook_util/test/hook_util_test_dll.h [delete] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/chrome_elf/hook_util/thunk_getter.cc [delete] https://crrev.com/320d596edc998927c4578323e5c0797963370ae9/chrome_elf/hook_util/thunk_getter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643 commit 4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643 Author: avi <avi@chromium.org> Date: Mon Aug 15 20:08:21 2016 Revert of [chrome_elf] Big cleanup and removing dependencies that recently crept in. Part 1. (patchset #9 id:300001 of https://codereview.chromium.org/2183263003/ ) Reason for revert: Win7 Tests (dbg)(1) started failing. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/51720 Excerpt from step 103, chrome_elf_unittests on Windows-7-SP1 chrome_elf_unittests on Windows-7-SP1 : [ RUN ] HookTest.IATHook Assertion failed: false, file c:\b\c\b\win\src\chrome_elf\hook_util\hook_util.cc, line 302 [43/49] HookTest.IATHook (TIMED OUT) Original issue's description: > [chrome_elf] Big cleanup and removing dependencies that recently crept in. PART 1. > > - Moving all crash related APIs into one place (and out of chrome_elf_main). > - Started to clean up external dependencies - starting with hook_utils. > - Removed dependency on base/win/iat_patch_function. > > BUG= 631771 > > Committed: https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58 > Cr-Commit-Position: refs/heads/master@{#411982} TBR=robertshield@chromium.org,pennymac@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 631771 Review-Url: https://codereview.chromium.org/2242323002 Cr-Commit-Position: refs/heads/master@{#412026} [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/BUILD.gn [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/blacklist.gypi [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/blacklist/blacklist.cc [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/blacklist/blacklist_interceptions.cc [add] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/blacklist/crashpad_helper.cc [add] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/blacklist/crashpad_helper.h [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/chrome_elf.gyp [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/chrome_elf_security.cc [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/chrome_elf_security.h [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/chrome_elf_util_unittest.cc [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/crash/crash_helper.cc [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/crash/crash_helper.h [modify] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/elf_imports_unittest.cc [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/hook_util/hook_util.cc [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/hook_util/hook_util.h [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/hook_util/test/hook_util_test.cc [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/hook_util/test/hook_util_test_dll.cc [delete] https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0/chrome_elf/hook_util/test/hook_util_test_dll.h [add] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/hook_util/thunk_getter.cc [add] https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643/chrome_elf/hook_util/thunk_getter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a commit 5446d89cd2b5e01f28c0b479eef46e2d9fd9385a Author: pennymac <pennymac@chromium.org> Date: Sat Aug 27 10:45:12 2016 [chrome_elf] Big cleanup and removing dependencies that recently crept in. PART 1. - Moving all crash related APIs into one place (and out of chrome_elf_main). - Started to clean up external dependencies - starting with hook_utils. - Removed dependency on base/win/iat_patch_function. BUG= 631771 Committed: https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58 Review-Url: https://codereview.chromium.org/2183263003 Cr-Original-Commit-Position: refs/heads/master@{#411982} Cr-Commit-Position: refs/heads/master@{#414898} [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/BUILD.gn [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/blacklist.gypi [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/blacklist/blacklist.cc [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/blacklist/blacklist_interceptions.cc [delete] https://crrev.com/cf4299907423c27d40182d17099d54a2e97e154c/chrome_elf/blacklist/crashpad_helper.cc [delete] https://crrev.com/cf4299907423c27d40182d17099d54a2e97e154c/chrome_elf/blacklist/crashpad_helper.h [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/chrome_elf.gyp [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/chrome_elf_main.cc [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/chrome_elf_security.cc [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/chrome_elf_security.h [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/chrome_elf_util_unittest.cc [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/crash/crash_helper.cc [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/crash/crash_helper.h [modify] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/elf_imports_unittest.cc [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/hook_util/hook_util.cc [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/hook_util/hook_util.h [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/hook_util/test/hook_util_test.cc [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/hook_util/test/hook_util_test_dll.cc [add] https://crrev.com/5446d89cd2b5e01f28c0b479eef46e2d9fd9385a/chrome_elf/hook_util/test/hook_util_test_dll.h [delete] https://crrev.com/cf4299907423c27d40182d17099d54a2e97e154c/chrome_elf/hook_util/thunk_getter.cc [delete] https://crrev.com/cf4299907423c27d40182d17099d54a2e97e154c/chrome_elf/hook_util/thunk_getter.h
Comment 1 by penny...@chromium.org
, Jul 26 2016