Application Window Icon For Sources On Desktop Capture Picker Window |
||||
Issue descriptionThe new window picker UI does not show application window's icon. It is better to have it for usability.
,
Jul 29 2016
sky@: Do you know how to get the icon image for an aura window. Namely, suppose that I have an instance of aura::Window, how can I get its icon image?
,
Aug 9 2016
Demonstration of the final icon capture effect.
,
Aug 9 2016
This is great! Thank you Qiang. Is it possible to have a few pixels of separation between the icon and the text? Maybe 2 or 4 pixels so that the icons have some breathing room? This is a huge usability improvement for our users. When will I be able to see it in Canary?
,
Aug 9 2016
Still need to ratify color format conversion. For the mock I just hard coded color format conversion by observation and guess.
,
Aug 9 2016
One thing I noticed is that for Mac, under current cocoa standard UI, it is not easy to display icon, because IKImageBrowser's cell only allows us to put in an image and a string. If we need to do that, we have to use general NSView and handle layouts and events completely by our code, which is a big project itself. As MD mirgration also affects Mac (namely later on Mac we can display general chrome UI rather than cocoa UI), icon display will be free when the migration is done, so I am not sure the need to display icon on cocoa UI.
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd commit c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd Author: qiangchen <qiangchen@chromium.org> Date: Wed Aug 10 18:37:52 2016 Aura Icon Capture For better usability, we wants to display icon for window capture. In this CL, we store the window icon into Aura::Window for aura windows. In the future CL, we will use display the icon onto the UI. BUG= 631604 Review-Url: https://codereview.chromium.org/2222703002 Cr-Commit-Position: refs/heads/master@{#411095} [modify] https://crrev.com/c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd/ui/aura/client/aura_constants.cc [modify] https://crrev.com/c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd/ui/aura/client/aura_constants.h [modify] https://crrev.com/c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd/ui/views/widget/native_widget_aura.cc [modify] https://crrev.com/c18dd6cae23fdfc04d3b5d2e3e38b122c06583dd/ui/views/widget/native_widget_aura.h
,
Aug 19 2016
shrike@: do you know when we can expect to launch general UI (controls in views::) on Mac? I just found to attach window icon to the source title is not quite easy for standard cocoa UI components. Thus wondering if we can just do it for general UI and wait for MD migration.
,
Aug 22 2016
Re #8, imo it's OK to land this for MD in M54 and until then launch without the application icon on Mac
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf commit da7b21cac1ded0c70cb330e4f76a1f7915e38ccf Author: qiangchen <qiangchen@chromium.org> Date: Mon Aug 22 18:40:59 2016 Icon Capture Utility For Linux, Windows and Mac For better usability, we wants to display icon for window capture. In this CL, we wrote utility classes which calls OS API to extract window icon images, and provide them to Chromium. In the future CL, we will use display the icon onto the UI. BUG= 631604 Review-Url: https://codereview.chromium.org/2246923002 Cr-Commit-Position: refs/heads/master@{#413483} [add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util.h [add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util_mac.mm [add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util_win.cc [add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util_x11.cc [modify] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/chrome_browser.gypi
,
Aug 22 2016
qiangchen@ - don't expect Views on the Mac to be generally available before the end of 2016. Re: displaying an image with the string, how are you doing that currently? I haven't used IKImageView, but it does not appear to have a title property - are you using some other object to lay out a collection of IKImageViews that also lets you assign a displayed title?
,
Aug 23 2016
OK. We are developing the general UI first, and then decide whether to do it for cocoa based on the feedback.
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7a9525b5e292c45f8d6db8091afed4ea5045aff commit e7a9525b5e292c45f8d6db8091afed4ea5045aff Author: qiangchen <qiangchen@chromium.org> Date: Tue Aug 30 06:06:26 2016 Display Window Icon In Picker UI In this CL, we display the window icon with the window source on the picker window for desktop capture. BUG= 631604 Review-Url: https://codereview.chromium.org/2270543003 Cr-Commit-Position: refs/heads/master@{#415199} [add] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/browser/media/window_icon_util_chromeos.cc [modify] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/browser/media/window_icon_util_x11.cc [modify] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc [modify] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [modify] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc [modify] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h [modify] https://crrev.com/e7a9525b5e292c45f8d6db8091afed4ea5045aff/chrome/chrome_browser.gypi
,
Aug 30 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by qiangchen@chromium.org
, Jul 26 2016