New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631604 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Application Window Icon For Sources On Desktop Capture Picker Window

Project Member Reported by qiangchen@chromium.org, Jul 26 2016

Issue description

The new window picker UI does not show application window's icon.

It is better to have it for usability.
 
Update: We need some content development besides UI development. Because the current DesktopMediaList does not extract the icon information from the OS, and thus cannot provide it to the UI control.
Cc: sky@chromium.org
sky@: Do you know how to get the icon image for an aura window.
Namely, suppose that I have an instance of aura::Window, how can I get its icon image?
Demonstration of the final icon capture effect.
Window capture with icon.png
65.7 KB View Download
This is great! Thank you Qiang. Is it possible to have a few pixels of separation between the icon and the text? Maybe 2 or 4 pixels so that the icons have some breathing room?  This is a huge usability improvement for our users. When will I be able to see it in Canary?
Still need to ratify color format conversion. For the mock I just hard coded color format conversion by observation and guess.  
One thing I noticed is that for Mac, under current cocoa standard UI, it is not easy to display icon, because IKImageBrowser's cell only allows us to put in an image and a string. If we need to do that, we have to use general NSView and handle layouts and events completely by our code, which is a big project itself.

As MD mirgration also affects Mac (namely later on Mac we can display general chrome UI rather than cocoa UI), icon display will be free when the migration is done, so I am not sure the need to display icon on cocoa UI. 
Cc: shrike@chromium.org
shrike@: do you know when we can expect to launch general UI (controls in views::) on Mac? 

I just found to attach window icon to the source title is not quite easy for standard cocoa UI components. Thus wondering if we can just do it for general UI and wait for MD migration.

Comment 9 by blum@chromium.org, Aug 22 2016

Re #8, imo it's OK to land this for MD in M54 and until then launch without the application icon on Mac
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf

commit da7b21cac1ded0c70cb330e4f76a1f7915e38ccf
Author: qiangchen <qiangchen@chromium.org>
Date: Mon Aug 22 18:40:59 2016

Icon Capture Utility For Linux, Windows and Mac

For better usability, we wants to display icon for window capture.

In this CL, we wrote utility classes which calls OS API to extract window icon images, and provide them to Chromium.

In the future CL, we will use display the icon onto the UI.

BUG= 631604 

Review-Url: https://codereview.chromium.org/2246923002
Cr-Commit-Position: refs/heads/master@{#413483}

[add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util.h
[add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util_mac.mm
[add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util_win.cc
[add] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/browser/media/window_icon_util_x11.cc
[modify] https://crrev.com/da7b21cac1ded0c70cb330e4f76a1f7915e38ccf/chrome/chrome_browser.gypi

qiangchen@ - don't expect Views on the Mac to be generally available before the end of 2016.

Re: displaying an image with the string, how are you doing that currently? I haven't used IKImageView, but it does not appear to have a title property - are you using some other object to lay out a collection of IKImageViews that also lets you assign a displayed title?

OK. We are developing the general UI first, and then decide whether to do it for cocoa based on the feedback.
Status: Fixed (was: Assigned)

Sign in to add a comment