New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631557 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Consolidate SetDisplayWorkAreaInsets calls into DisplayObserver

Project Member Reported by hariank@google.com, Jul 26 2016

Issue description

Currently SetDisplayWorkAreaInsets from ShellObserver is used to signal work area changes. Instead, use OnDisplayMetricsChanged in DisplayObserver.

 

Comment 1 by hariank@google.com, Jul 26 2016

Owner: hariank@google.com
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 27 2016

Labels: Hotlist-Google
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42e8f5758b28d3da954b86692f5a4f22707d212

commit c42e8f5758b28d3da954b86692f5a4f22707d212
Author: hariank <hariank@google.com>
Date: Thu Jul 28 23:50:28 2016

Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG= 631557 

Review-Url: https://codereview.chromium.org/2185773002
Cr-Commit-Position: refs/heads/master@{#408507}

[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/common/shell_observer.h
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/common/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/common/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/display/display_manager.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/shell.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212/components/exo/wayland/server.cc

Comment 4 by hariank@google.com, Aug 2 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5da19c5e8c079e75e47550d04c8dd151219a4326

commit 5da19c5e8c079e75e47550d04c8dd151219a4326
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Sep 13 00:09:30 2016

Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG= 631557 , 645210 
Committed: https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212
Cr-Commit-Position: refs/heads/master@{#408507}

Review URL: https://codereview.chromium.org/2335963002 .

Cr-Commit-Position: refs/branch-heads/2785@{#879}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/common/shell_observer.h
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/common/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/common/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/display/display_manager.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/shell.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/5da19c5e8c079e75e47550d04c8dd151219a4326/components/exo/wayland/server.cc

Sign in to add a comment