New issue
Advanced search Search tips

Issue 631554 link

Starred by 2 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

EffectiveConnectionType in NQE should be moved to a different file

Project Member Reported by tbansal@chromium.org, Jul 26 2016 
EffectiveConnectionType in NQE should be moved to a different file.

Currently, EffectiveConnectionType enum is defined in the class net::NetworkqualityEstimator. The problem with this approach is that
(i) Internal classes in //net/network_quality_estimator.h can't access on EffectiveConnectionType enum since that adds cyclic dependency between the internal class and NQE class.
(ii) Consumers of NQE that only access EffectiveConnectionType enum have to be dependent on the //net/nqe/network_quality_estimator.h, a large header file.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eb690178fe3818530e84ee9bffffda40ca41edd

commit 3eb690178fe3818530e84ee9bffffda40ca41edd
Author: tbansal <tbansal@chromium.org>
Date: Fri Jul 29 08:55:58 2016

NQE: Move ECT to net:: namespace

Move EffectiveConnectionType from NetworkQualityEstimator
class to net:: namespace

Also, move EffectiveConnectionType to a separate file in
//net/nqe/effective_connection_type.h.

TBR=nasko@chromium.org,dimich@chromium.org

BUG= 631552 , 631554 

Review-Url: https://codereview.chromium.org/2183153002
Cr-Commit-Position: refs/heads/master@{#408605}

[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/net/nqe/ui_network_quality_estimator_service.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/browser/loader/resource_loader_unittest.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/child/weburlresponse_extradata_impl.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/child/weburlresponse_extradata_impl.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/common/resource_messages.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/public/common/resource_response_info.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/public/common/resource_response_info.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/renderer/effective_connection_type_helper.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/content/renderer/effective_connection_type_helper.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/net/net.gypi
[add] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/net/nqe/effective_connection_type.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/3eb690178fe3818530e84ee9bffffda40ca41edd/net/nqe/network_quality_estimator_unittest.cc

Comment 2 by tbansal@chromium.org, Aug 3 2016

Status: Fixed (was: Started)

Comment 3 by tbansal@chromium.org, Feb 14 2017

Components: Internals>Network>NetworkQuality
►

Sign in to add a comment