Number of sampled whitelisted downloads is much lower than expectation |
|||||||
Issue descriptionAfter we started to sample whitelisted download since M50, SB received roughly 350 sampled pings per day. This is far below the number we need to do a meaningful audit of download privacy whitelist. Based on UMA metrics of whitelisted download, we estimated that there should be around 10K sampled whitelisted download per day. Need to investigate why the actual number we get is so low and how to increase the number of samples without increasing the sampling rate.
,
Aug 3 2016
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/389ba5efb8a7659573f1c72095c4eb23275612ed commit 389ba5efb8a7659573f1c72095c4eb23275612ed Author: jialiul <jialiul@chromium.org> Date: Fri Aug 05 19:14:48 2016 Skip certificate whitelist checking if download URL already matches whitelist and gets sampled. This will speed up the whitelisting checking process for some downloads, and would potentially slightly increase the number of whitelisted ping we get. BUG= 631550 Review-Url: https://codereview.chromium.org/2201213007 Cr-Commit-Position: refs/heads/master@{#410133} [modify] https://crrev.com/389ba5efb8a7659573f1c72095c4eb23275612ed/chrome/browser/safe_browsing/download_protection_service.cc [modify] https://crrev.com/389ba5efb8a7659573f1c72095c4eb23275612ed/chrome/browser/safe_browsing/download_protection_service_unittest.cc
,
Aug 5 2016
,
Aug 5 2016
,
Aug 8 2016
Verified in Canary. Request merge into M53. Thanks!
,
Aug 8 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2df48ee378d55469881502aff2690fd743d06d25 commit 2df48ee378d55469881502aff2690fd743d06d25 Author: Jialiu Lin <jialiul@chromium.org> Date: Mon Aug 08 19:12:36 2016 Skip certificate whitelist checking if download URL already matches whitelist and gets sampled. This will speed up the whitelisting checking process for some downloads, and would potentially slightly increase the number of whitelisted ping we get. BUG= 631550 Review-Url: https://codereview.chromium.org/2201213007 Cr-Commit-Position: refs/heads/master@{#410133} (cherry picked from commit 389ba5efb8a7659573f1c72095c4eb23275612ed) Review URL: https://codereview.chromium.org/2222843006 . Cr-Commit-Position: refs/branch-heads/2785@{#531} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/2df48ee378d55469881502aff2690fd743d06d25/chrome/browser/safe_browsing/download_protection_service.cc [modify] https://crrev.com/2df48ee378d55469881502aff2690fd743d06d25/chrome/browser/safe_browsing/download_protection_service_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jialiul@chromium.org
, Aug 2 2016