Chrome seems to hang sometimes when zooming |
||||||||||||||
Issue descriptionChrome seems to hang sometimes when zooming. We should disable the pinch zoom on all ChromeOS platforms for now.
,
Jul 27 2016
,
Jul 27 2016
Approving merge to M53 cros.
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/gestures/+/5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4 commit 5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4 Author: Amirhossein Simjour <asimjour@google.com> Date: Tue Jul 26 18:18:02 2016 Revert "Pinch zoom is enabled by default" This reverts commit 9d27a36fdd3727d7fdebe96fd24013bc601a58df. BUG= chromium:631549 TEST=Manually tested and related regression tests are disbaled Change-Id: Ia8c566eec84703a5d86ac9b4b019d51165b2281d Reviewed-on: https://chromium-review.googlesource.com/363491 Commit-Ready: Amirhossein Simjour <asimjour@chromium.org> Tested-by: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Andrew de los Reyes <adlr@chromium.org> [modify] https://crrev.com/5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4/src/immediate_interpreter.cc [modify] https://crrev.com/5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4/src/immediate_interpreter_unittest.cc
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/gestures/+/9b73efa9bb13619bddb8eba8b65f9ab85767aaa8 commit 9b73efa9bb13619bddb8eba8b65f9ab85767aaa8 Author: Amirhossein Simjour <asimjour@google.com> Date: Tue Jul 26 18:18:02 2016 Revert "Pinch zoom is enabled by default" This reverts commit 9d27a36fdd3727d7fdebe96fd24013bc601a58df. BUG= chromium:631549 TEST=Manually tested and related regression tests are disbaled Change-Id: Ia8c566eec84703a5d86ac9b4b019d51165b2281d Reviewed-on: https://chromium-review.googlesource.com/363517 Reviewed-by: Andrew de los Reyes <adlr@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Tested-by: Amirhossein Simjour <asimjour@chromium.org> [modify] https://crrev.com/9b73efa9bb13619bddb8eba8b65f9ab85767aaa8/src/immediate_interpreter.cc [modify] https://crrev.com/9b73efa9bb13619bddb8eba8b65f9ab85767aaa8/src/immediate_interpreter_unittest.cc
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touchpad-tests/+/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069 commit e6984c779d00fa96fc35cfbac8d5d4c2b4daf069 Author: Amirhossein Simjour <asimjour@google.com> Date: Tue Jul 26 18:26:36 2016 Disable pinch zoom regression tests Regression tests that are related to touchpad pinch zoom are disabled. BUG= chromium:631549 TEST=Manually tested Change-Id: I8962099adea4d0f88252ecc0da487b1de64f6bd5 Reviewed-on: https://chromium-review.googlesource.com/363558 Reviewed-by: Andrew de los Reyes <adlr@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Tested-by: Amirhossein Simjour <asimjour@chromium.org> [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/scroll_before_pinch_2.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_5.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_6.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_3.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_1.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_2.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_4.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/scroll_before_pinch_1.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/motion_resting_thumb.py [modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/move_before_pinch.py
,
Jul 28 2016
,
Jul 29 2016
Should we mark this fixed? It is already merged into M53.
,
Jul 30 2016
rohitbm@ have we validated this fix on today's build? Can we close this out?
,
Jul 30 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2016
I will have this fix verified today.
,
Aug 1 2016
,
Aug 1 2016
AU'd from M52 Beta (8350.60.0 52.0.2743.85) to M53 Beta (8530.35.0 53.0.2785.36) samus. Pinch to zoom is still enabled and working on web pages. Reopening the bug.
,
Aug 1 2016
,
Aug 1 2016
asimjour@ Need clarification. Is this related to 'touchpad' pinchzoom or 'touchscreen' pinch zoom?
,
Aug 1 2016
,
Aug 1 2016
Pramod is re-verifying the bug.
,
Aug 1 2016
Tested on 8530.35.0 build. Touchpad zoom disabled -- cyan,celes, samus Touchpad zoom enabled -- minnie
,
Aug 1 2016
Is this just minnie or more devices could have this enabled? if yes, do we know which ones?
,
Aug 1 2016
Amir, looks like we may need to fix Minnie and any other platforms that were forced in via xorg-conf
,
Aug 1 2016
Nevermind, we put reverts in to fix Minnie, which was the only one left.
,
Aug 2 2016
Tested on veyron-minnie 8530.35.1 version and the touchpad zoom is disabled.
,
Aug 2 2016
Do we need to keep the bug opened for the real fix?
,
Aug 5 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 5 2016
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by adlr@chromium.org
, Jul 26 2016