New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631549 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chrome seems to hang sometimes when zooming

Project Member Reported by asimjour@chromium.org, Jul 26 2016

Issue description

Chrome seems to hang sometimes when zooming. We should disable the pinch zoom on all ChromeOS platforms for now.


 

Comment 1 by adlr@chromium.org, Jul 26 2016

Labels: Merge-Request-53 ReleaseBlock-Beta
CLs have been +2ed:

https://chromium-review.googlesource.com/#/c/363550/1
https://chromium-review.googlesource.com/#/c/363491/1

Requesting merge to R53

Comment 2 by josa...@google.com, Jul 27 2016

Labels: M-53
Labels: -Merge-Request-53 Merge-Approved-53
Approving merge to M53 cros.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/gestures/+/5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4

commit 5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4
Author: Amirhossein Simjour <asimjour@google.com>
Date: Tue Jul 26 18:18:02 2016

Revert "Pinch zoom is enabled by default"

This reverts commit 9d27a36fdd3727d7fdebe96fd24013bc601a58df.

BUG= chromium:631549 
TEST=Manually tested and related regression tests are disbaled

Change-Id: Ia8c566eec84703a5d86ac9b4b019d51165b2281d
Reviewed-on: https://chromium-review.googlesource.com/363491
Commit-Ready: Amirhossein Simjour <asimjour@chromium.org>
Tested-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4/src/immediate_interpreter.cc
[modify] https://crrev.com/5a656849c7d2b0d0ddbe0ac6d300c1e2fada0bb4/src/immediate_interpreter_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/gestures/+/9b73efa9bb13619bddb8eba8b65f9ab85767aaa8

commit 9b73efa9bb13619bddb8eba8b65f9ab85767aaa8
Author: Amirhossein Simjour <asimjour@google.com>
Date: Tue Jul 26 18:18:02 2016

Revert "Pinch zoom is enabled by default"

This reverts commit 9d27a36fdd3727d7fdebe96fd24013bc601a58df.

BUG= chromium:631549 
TEST=Manually tested and related regression tests are disbaled

Change-Id: Ia8c566eec84703a5d86ac9b4b019d51165b2281d
Reviewed-on: https://chromium-review.googlesource.com/363517
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Tested-by: Amirhossein Simjour <asimjour@chromium.org>

[modify] https://crrev.com/9b73efa9bb13619bddb8eba8b65f9ab85767aaa8/src/immediate_interpreter.cc
[modify] https://crrev.com/9b73efa9bb13619bddb8eba8b65f9ab85767aaa8/src/immediate_interpreter_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/touchpad-tests/+/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069

commit e6984c779d00fa96fc35cfbac8d5d4c2b4daf069
Author: Amirhossein Simjour <asimjour@google.com>
Date: Tue Jul 26 18:26:36 2016

Disable pinch zoom regression tests

Regression tests that are related to touchpad pinch zoom are disabled.

BUG= chromium:631549 
TEST=Manually tested

Change-Id: I8962099adea4d0f88252ecc0da487b1de64f6bd5
Reviewed-on: https://chromium-review.googlesource.com/363558
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Tested-by: Amirhossein Simjour <asimjour@chromium.org>

[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/scroll_before_pinch_2.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_5.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_6.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_3.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_1.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_2.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/pinch_zoom_4.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/scroll_before_pinch_1.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/motion_resting_thumb.py
[modify] https://crrev.com/e6984c779d00fa96fc35cfbac8d5d4c2b4daf069/tests/link/move_before_pinch.py

Cc: kathrelk...@chromium.org
Should we mark this fixed? It is already merged into M53.
rohitbm@ have we validated this fix on today's build? Can we close this out?
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
I will have this fix verified today.
Components: Internals>Input>Touch>Screen
Status: Assigned (was: Fixed)
AU'd from M52 Beta (8350.60.0	52.0.2743.85) to M53 Beta (8530.35.0	53.0.2785.36) samus.

Pinch to zoom is still enabled and working on web pages.

Reopening the bug.
Cc: rohi...@chromium.org
asimjour@ Need clarification. Is this related to 'touchpad' pinchzoom or 'touchscreen' pinch zoom?
Components: -Internals>Input>Touch>Screen Internals>Input>Touch>Pad
Cc: pbath...@chromium.org
Status: Fixed (was: Assigned)
Pramod is re-verifying the bug.
Status: Assigned (was: Fixed)
Tested on 8530.35.0 build.

Touchpad zoom disabled --  cyan,celes, samus

Touchpad zoom enabled -- minnie
Is this just minnie or more devices could have this enabled? if  yes, do we know which ones?

Comment 20 by adlr@chromium.org, Aug 1 2016

Amir, looks like we may need to fix Minnie and any other platforms that were forced in via xorg-conf

Comment 21 by adlr@chromium.org, Aug 1 2016

Nevermind, we put reverts in to fix Minnie, which was the only one left.
Status: Verified (was: Assigned)
Tested on veyron-minnie 8530.35.1 version and the touchpad zoom is disabled.
Do we need to keep the bug opened for the real fix?
Project Member

Comment 24 by sheriffbot@chromium.org, Aug 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-53 Merge-Merged

Sign in to add a comment