New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631537 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

debug builds should be component builds by default

Project Member Reported by dpranke@chromium.org, Jul 26 2016

Issue description

Static debug builds aren't really supported in Chromium (we don't have any builders that build them), and on some platforms (e.g., Windows), they flat out won't work.

There has been discussion off and on about whether we should support them, and whether we should default to shared (which tends to be a better dev experience since it builds faster and takes less disk space, but is farther away from the configuration we ship).

Historically, we couldn't easily change this in GYP because debug and release had to be either both static or both shared. However, in GN, there's no reason we can't have different defaults here.
 
Labels: -Pri-3 Pri-2
Status: Started (was: Available)
Proposed CL:

https://codereview.chromium.org/2205573003/
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e90548f18cc7ce931c3fda659ebad2ebb9bc3f0

commit 5e90548f18cc7ce931c3fda659ebad2ebb9bc3f0
Author: dpranke <dpranke@chromium.org>
Date: Thu Aug 04 01:19:55 2016

Make debug builds component builds by default.

(Except on iOS, where component builds aren't supported).

R=brettw@chromium.org
BUG= 631537 

Review-Url: https://codereview.chromium.org/2205573003
Cr-Commit-Position: refs/heads/master@{#409692}

[modify] https://crrev.com/5e90548f18cc7ce931c3fda659ebad2ebb9bc3f0/build/config/BUILDCONFIG.gn

Status: Fixed (was: Started)

Sign in to add a comment