New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631531 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug



Sign in to add a comment

Clang formatting problem for empty function bodies

Project Member Reported by jkarlin@chromium.org, Jul 26 2016

Issue description

clang-format produced code that (choose all that apply): 
- Doesn't match Chromium style

Here's the code before formatting:

  virtual void NotifyCacheCreated(
      const std::string& cache_name,
      std::unique_ptr<CacheStorageCacheHandle> cache_handle) {};

Here's the code after formatting:

  virtual void NotifyCacheCreated(
      const std::string& cache_name,
      std::unique_ptr<CacheStorageCacheHandle> cache_handle){};

Here's how it ought to look:

  virtual void NotifyCacheCreated(
      const std::string& cache_name,
      std::unique_ptr<CacheStorageCacheHandle> cache_handle) {};

Code review link for full files/context:

https://codereview.chromium.org/2186433004/diff/20001/content/browser/cache_storage/cache_storage.cc

 

Comment 1 by thakis@chromium.org, Jul 26 2016

Remove the semicolon, try again
Status: WontFix (was: Untriaged)
*smacks head*

thanks!

Sign in to add a comment