New issue
Advanced search Search tips

Issue 631526 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640781
issue 644860



Sign in to add a comment

Port DimWindow to mash

Project Member Reported by sky@chromium.org, Jul 26 2016

Issue description

It should be fairly straightforward to get this working with mash.
 

Comment 1 by sky@chromium.org, Aug 24 2016

Blocking: 640781

Comment 2 by sky@chromium.org, Aug 24 2016

Labels: Proj-Mustash-Mash
Components: MUS

Comment 4 by sky@chromium.org, Sep 7 2016

Blocking: 644860

Comment 5 by sky@chromium.org, Sep 7 2016

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b733d4184e6a91eebd951cae60c871118d4cc2a2

commit b733d4184e6a91eebd951cae60c871118d4cc2a2
Author: sky <sky@chromium.org>
Date: Fri Sep 09 23:18:38 2016

Refactors DimWindow and moves to ash/common

DimWindow was both an aura::Window and had some logic. As that won't
work at all in mash (and we generally don't subclass aura::Windows)
I've converted it to have a WmWindow. I also renamed it to
WindowDimmer.

BUG= 631526 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2320273002
Cr-Commit-Position: refs/heads/master@{#417755}

[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/BUILD.gn
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/aura/wm_window_aura.h
[add] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm/window_dimmer.cc
[add] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm/window_dimmer.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm_shell.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm_window.h
[add] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm_window_user_data.h
[add] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/common/wm_window_user_data_unittest.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/root_window_controller.cc
[delete] https://crrev.com/a452e2357b4cbd498bb728fb7b5f4006123d111d/ash/wm/dim_window.cc
[delete] https://crrev.com/a452e2357b4cbd498bb728fb7b5f4006123d111d/ash/wm/dim_window.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/screen_dimmer.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/screen_dimmer.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/screen_dimmer_unittest.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/screen_pinning_controller.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/screen_pinning_controller.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/b733d4184e6a91eebd951cae60c871118d4cc2a2/ash/wm/system_modal_container_layout_manager_unittest.cc

Comment 7 by sky@chromium.org, Sep 15 2016

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 9 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment