New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631524 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 672587



Sign in to add a comment

Add necessary fields to ui.mojom.CompositionEvent

Project Member Reported by moshayedi@chromium.org, Jul 26 2016

Issue description

Some composition events require some data fields which we need to include in ui.mojom.CompositionEvent.

 
Labels: Proj-Mustash
Components: Internals>MUS
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead76a6a60d2db90bec1d257f47422c2e059db1c

commit ead76a6a60d2db90bec1d257f47422c2e059db1c
Author: moshayedi <moshayedi@chromium.org>
Date: Sat Dec 03 02:26:47 2016

IME for Mus: Add ui.mojom.CompositionText and its struct traits.

- Adds ui.mojom.CompositionUnderline and ui.mojom.CompositionText.
- Adds corresponding struct traits + unittest for struct traits.
- Breaks ui.mojom.TextInputClient::OnCompositionEvent() into multiple
  functions, each corresponding to a function in ui::TextInputClient.

BUG= 631524 

Review-Url: https://codereview.chromium.org/2539453002
Cr-Commit-Position: refs/heads/master@{#436143}

[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/chrome/browser/ui/views/ime_driver_mus.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/chrome/browser/ui/views/ime_driver_mus.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/ime/ime_registrar_impl.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/ime/ime_server_impl.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/ime/ime_unittest.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/ime/test_ime_driver/test_ime_application.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/ime/test_ime_driver/test_ime_driver.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/ime/test_ime_driver/test_ime_driver.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/BUILD.gn
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/BUILD.gn
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/OWNERS
[rename] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/ime.mojom
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/ime.typemap
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/ime_struct_traits.cc
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/ime_struct_traits.h
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/ime_struct_traits_test.mojom
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/ime_struct_traits_unittest.cc
[add] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/public/interfaces/ime/typemaps.gni
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/services/ui/service.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/aura/mus/input_method_mus.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/aura/mus/input_method_mus.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/aura/mus/text_input_client_impl.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/aura/mus/text_input_client_impl.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/base/ime/BUILD.gn
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/views/mus/input_method_mus.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/views/mus/input_method_mus.h
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/views/mus/text_input_client_impl.cc
[modify] https://crrev.com/ead76a6a60d2db90bec1d257f47422c2e059db1c/ui/views/mus/text_input_client_impl.h

Blocking: -548407 672587
Labels: -Pri-3 Pri-1
Status: Fixed (was: Available)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment