New issue
Advanced search Search tips

Issue 631522 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MD settings page - after visiting display settings Alt+Left no longer works as [back] shortcut

Project Member Reported by varkha@chromium.org, Jul 26 2016

Issue description

MD settings page - after visiting display settings Alt+Left or Alt+Right no longer work as [back] / [forward] shortcuts. Using hardware buttons (F1 / F2) still works.
Seems specific to the display settings sub-page, neighbor pages (keyboard or touchpad settings) do not have this effect.

bugs: repro steps (I did X and expected Y but Z happened!)
1. open chrome://md-settings
2. Click "Displays"
3. Press Alt+Left

Expected - back to the root settings page.

Actual - nothing.

 
Cc: steve...@chromium.org
Labels: Hotlist-MD-Settings-Navigation
@stevenjb -- anything we could be doing on the Displays page that would intercept Alt+Left? Maybe code for moving displays?
Labels: M-54
Owner: steve...@chromium.org
Status: Assigned (was: Available)
Does clicking on the back icon work?

It is certainly possible, we use alt + arrows to adjust resolution.

Comment 3 by varkha@chromium.org, Jul 28 2016

#2, Yes, using F1 / F2 still works.
Labels: -M-54 M-55
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9235cda388a249ed4149b7b3f36b2c06b17ccc52

commit 9235cda388a249ed4149b7b3f36b2c06b17ccc52
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Sep 29 02:52:11 2016

MD Settings: Display: Move event listeners to dialog open/close

BUG= 631522 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2371993002
Cr-Commit-Position: refs/heads/master@{#421729}

[modify] https://crrev.com/9235cda388a249ed4149b7b3f36b2c06b17ccc52/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Sign in to add a comment