Issue 631513 link

Starred by 7 users

Issue metadata

Status:	Fixed
Merged:	issue 455764
Owner:	thestig@chromium.org
Closed:	Nov 2016
Cc:	rob@robwu.nl nyerramilli@chromium.org thestig@chromium.org creis@chromium.org █ sgu...@chromium.org alex...@chromium.org █ ranjitkan@chromium.org █ nasko@chromium.org wfh@chromium.org
Components:	Internals>Printing Internals>Sandbox>SiteIsolation
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	1
Type:	Bug
M-55 M-56 M-54 Hotlist-Merge-Approved Proj-IsolateExtensions-BlockingLaunch merge-merged-2883

Blocked on:
issue 665909

Printing from an OOPIF does not work

Project Member Reported by alex...@chromium.org, Jul 26 2016

Issue description

What steps will reproduce the problem?
(1) Start Chrome with --site-per-process
(2) Navigate to http://csreis.github.io/tests/cross-site-iframe-simple.html
(3) Open DevTools for the out-of-process subframe and execute "print()"

What is the expected output?

Print dialog shows up, with the preview page filled with the subframe contents.  This is what happens without --site-per-process.

What do you see instead?
Nothing happens.

Comment 1 by lukasza@chromium.org, Jul 26 2016

Cc: thestig@chromium.org

+thestig@ in case this is related to  issue 455764

Comment 2 by alex...@chromium.org, Oct 6 2016

Cc: rob@robwu.nl nyerramilli@chromium.org ranjitkan@chromium.org nasko@chromium.org

 Issue 650952  has been merged into this issue.

Comment 3 by thestig@chromium.org, Oct 6 2016

Mergedinto: 455764
Status: Duplicate (was: Available)

Comment 4 by thestig@chromium.org, Oct 6 2016

Status: Untriaged (was: Duplicate)

Unmerging.

Comment 5 by rob@robwu.nl, Oct 7 2016

Is it possible to solve this ASAP, or at least before Chrome 55 hits Stable / Beta?

Comment 6 by thestig@chromium.org, Oct 7 2016

Components: Internals>Printing
Labels: M-55 ReleaseBlock-Stable

Well, today is the branch cut, so we'd have to merge.

I'll take a very brief look at this and either fix it or run away in fear.

Comment 7 by alex...@chromium.org, Oct 7 2016

Status: Available (was: Untriaged)

I was looking at this for a bit earlier today.  At least part of the problem is that the print messages like PrintHostMsg_SetupScriptedPrintPreview, which seems to be the first message to be sent when calling print(), are routed through the swapped-out RenderView, and so they get dropped by the swapped-out message filtering.

As an experiment, I added all messages from print_messages.h into the allowed messages in swapped_out_messages.cc.  That got me as far as showing the print preview dialog, but then when loading the actual preview image in it, I hit the following DCHECK:

[1:1:1006/183010:FATAL:print_web_view_helper.cc(2012)] Check failed: INITIALIZED == state_ (1 vs. 0)
#0 0x7fee050eeb1e base::debug::StackTrace::StackTrace()
#1 0x7fee0515c95f logging::LogMessage::~LogMessage()
#2 0x7fee09ea52ad printing::PrintWebViewHelper::PrintPreviewContext::OnPrintPreview()
#3 0x7fee09ea3689 printing::PrintWebViewHelper::OnPrintPreview()
#4 0x7fee062a4999 _ZN4base20DispatchToMethodImplIPN10extensions17SandboxedUnpackerEMS2_FvRKNS_15DictionaryValueEERKSt5tupleIJS4_EEJLm0EEEEvRKT_T0_OT1_NS_13IndexSequenceIJXspT2_EEEE
#5 0x7fee09eaebd8 _ZN4base16DispatchToMethodIPN8printing18PrintWebViewHelperEMS2_FvRKNS_15DictionaryValueEERKSt5tupleIJS4_EEEEvRKT_T0_OT1_
#6 0x7fee09eaeb5f _ZN3IPC16DispatchToMethodIN8printing18PrintWebViewHelperEMS2_FvRKN4base15DictionaryValueEEvSt5tupleIJS4_EEEEvPT_T0_PT1_RKT2_
#7 0x7fee09eac7a1 _ZN3IPC8MessageTI26PrintMsg_PrintPreview_MetaSt5tupleIJN4base15DictionaryValueEEEvE8DispatchIN8printing18PrintWebViewHelperES9_vMS9_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#8 0x7fee09ea29df printing::PrintWebViewHelper::OnMessageReceived()
#9 0x7fee00245636 content::RenderViewImpl::OnMessageReceived()
#10 0x7fedfd364b2b IPC::MessageRouter::RouteMessage()
#11 0x7fedfe5b7f88 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage()
#12 0x7fedfd364aae IPC::MessageRouter::OnMessageReceived()
#13 0x7fedfe5bc3ee content::ChildThreadImpl::OnMessageReceived()
#14 0x7fedfd304168 IPC::ChannelProxy::Context::OnDispatchMessage()

So it's likely that to fix this properly, we need to move some (all?) of these print messages to be frame-level or widget-level, and probably fix up some of the state bookkeeping as well.

Comment 8 by thestig@chromium.org, Oct 7 2016

Owner: thestig@chromium.org
Status: Assigned (was: Available)

Taking the bug for now.

Comment 9 by thestig@chromium.org, Oct 7 2016

Labels: -M-55 M-54

Comment 10 by nasko@chromium.org, Oct 7 2016

Labels: -ReleaseBlock-Stable

Removing ReleaseBlock-Stable, as this bug is not present in default config of M54. The Isolate Extension work is controlled through field trial and is not enabled for stable yet. However, we have been planning to ship in M54, so let's aim to fix it there if possible and enable through field trial once we are ready.

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e440d8cb3d9ff035fa588fd0b13b73f3deaa9568

commit e440d8cb3d9ff035fa588fd0b13b73f3deaa9568
Author: nasko <nasko@chromium.org>
Date: Wed Oct 12 23:07:56 2016

Add UMA for documents calling window.print().

BUG= 631513 

Review-Url: https://codereview.chromium.org/2412753002
Cr-Commit-Position: refs/heads/master@{#424898}

[modify] https://crrev.com/e440d8cb3d9ff035fa588fd0b13b73f3deaa9568/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e440d8cb3d9ff035fa588fd0b13b73f3deaa9568/tools/metrics/histograms/histograms.xml

Comment 12 by nasko@chromium.org, Oct 13 2016

Labels: Merge-Request-55

I would like to merge r424898 into beta and stable, so we can gather data of how common is printing from an out-of-process iframe. Let's start with M55.

Comment 13 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M55 (branch: 2883)

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d2b64c5d878d81db824e4ff0920760297dc43b8

commit 7d2b64c5d878d81db824e4ff0920760297dc43b8
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Oct 13 22:35:57 2016

Add UMA for documents calling window.print().

BUG= 631513 

Review-Url: https://codereview.chromium.org/2412753002
Cr-Commit-Position: refs/heads/master@{#424898}
(cherry picked from commit e440d8cb3d9ff035fa588fd0b13b73f3deaa9568)

Review URL: https://codereview.chromium.org/2415953003 .

Cr-Commit-Position: refs/branch-heads/2883@{#99}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/7d2b64c5d878d81db824e4ff0920760297dc43b8/content/renderer/render_view_impl.cc
[modify] https://crrev.com/7d2b64c5d878d81db824e4ff0920760297dc43b8/tools/metrics/histograms/histograms.xml

Comment 15 by thestig@chromium.org, Oct 17 2016

I have a somewhat complete CL to convert PrintWebViewHelper from a RenderViewObserver to a RenderFrameObserver: https://codereview.chromium.org/2426503002

Without --site-per-process, it works as normal and messages are being routed to the right RenderFrame{Host}. With --site-per-process, if I:

(1) Highlight text in the out-of-process subframe
(2) Right click in the subframe and select print

Expected: Print preview pops up for the subframe
Actual: PrintMsg_InitiatePrintPreview gets sent but not received

If I try the original steps:
(1) Open DevTools for the out-of-process subframe and execute "print()"

Expected: Print preview pops up for the subframe
Actual:
[1:1:1016/231444:FATAL:WebRemoteFrameImpl.cpp(113)] Check failed: false. 
#0 base::debug::StackTrace::StackTrace()
#1 logging::LogMessage::~LogMessage()
#2 blink::WebRemoteFrameImpl::scrollOffset()
#3 blink::WebRemoteFrameImpl::scrollOffset()
#4 printing::PrepareFrameAndViewForPrint::ResizeForPrinting()
#5 printing::PrepareFrameAndViewForPrint::StartPrinting()
#6 printing::PrintWebViewHelper::PrintPreviewContext::CreatePreviewDocument()
#7 printing::PrintWebViewHelper::CreatePreviewDocument()

Does anyone want to try out my CL and see if I'm doing something wrong or there is a problem elsewhere with OOPIF?

Comment 16 by rob@robwu.nl, Oct 17 2016

@Lei

About the first issue:
In chrome/browser/printing/print_view_manager_base.cc, PrintViewManagerBase::PrintNowInternal should use web_contents()->SendToAllFrames instead of Send if you want to reach all frames.

About the second issue:
ResizeForPrinting (and its counterpart RestoreSize) are seemingly designed for views; if you use OOP frames then frame() could end up referencing a frame in another process. I don't know why the resize logic is there, but it seems to only be relevant for the top-most frame of the printed page.
I have added an early return in case the frame is not the main frame, and the print preview does appear now (should you maybe check whether the frame is equal to the frame from where the print is requested, instead of the main frame?)

With the above changes, print() works. The whole tab crashes when I select text and prints though, but I guess that you can debug further.

Hope this helps!


Here is the test case that I used:

fram.htm
Child
<button onclick=print()>print()</button>

index.html
<!-- Start server at port 3000 and visit localhost:3000 -->
<!-- Case 1: Select "child", right-click, print -->
<!-- Case 2: Click button -->
Top
<iframe src="http://127.0.0.1:3000/fram.htm"></iframe>

print-preview.diff
1.8 KB Download

Comment 17 by thestig@chromium.org, Oct 18 2016

Rob, thanks for looking. I don't want to SendToAllFrames() right now. I want to just target the subframe in my test cases.

When printing the top frame with --site-per-process, the print preview will have a hole where the subframe is. I'm fine with that for now. We know we'll need to stitch frames together eventually.

I'll look at ResizeForPrinting() some more...

Comment 18 by ranjitkan@chromium.org, Oct 18 2016

Labels: Needs-Feedback

Rechecked this on chrome version 55.0.2883.18 on Windows 10, MAC 10.11.6, Ubuntu 14.04. 

Followed the below steps:
=========================
1) Launch chrome with flag --site-per-process
2) Navigated to http://csreis.github.io/tests/cross-site-iframe-simple.html
3) Opened dev console and entered "print();" command
4) Observed that print preview was displayed but the content inside the frame was not displayed (Screen Shot Attached)

Followed the same behavior without the flag and observed that the content inside the frame was also displayed in the preview (Screenshot attached).

Could someone please confirm if this behavior is also intended when chrome is launched with flag --site-per-process

	With Out Flag.png 224 KB View Download

	With Flag.png 174 KB View Download

	Flag in Chrome Version.png 147 KB View Download

Comment 19 by creis@chromium.org, Oct 18 2016

Labels: -Needs-Feedback

Comment 18: It looks like you missed part of step 3.  We want the print() command to run inside the subframe, not in the main frame.  This requires right clicking on the iframe and choosing Inspect, which opens a separate DevTools instance from the main frame's DevTools (until  issue 652783  is resolved).  With those steps, we want the print preview to just show the iframe's contents.  In contrast, the missing iframe you saw is being tracked in  issue 455764 .

Comment 20 by creis@chromium.org, Oct 21 2016

Labels: -Pri-3 M-55 M-56 Pri-1

Comment 15: Do you still need advice from anyone on the OOPIF team to make progress?  We're happy to help, but it looked like Rob's reply might have helped.  (We're hoping to get a fix in for M56 for sure, and if it's mergeable to M55 that's even better.)

Comment 21 by nasko@chromium.org, Oct 24 2016

Labels: Proj-IsolateExtensions-BlockingLaunch

Adding a blocking launch label. 

thestig@, let us know if we can be of any assistance.

Comment 22 by thestig@chromium.org, Oct 24 2016

If you have any thoughts on where PrintMsg_InitiatePrintPreview went in comment 15, that can certainly help. I just have too many bugs that are all P1 and nobody else to pass them off to.

Comment 23 by rob@robwu.nl, Oct 25 2016

Send in PrintViewManagerBase::PrintNowInternal is WebContentsImpl::Send, which sends the message to the view, and most likely not reach out-of-process frames.

I would look for a RenderFrameHost* to get it to work for OOP frames. How about scripted_print_rfh_->Send with a fallback to the current Send (WebContentsImpl::Send)?

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d2b64c5d878d81db824e4ff0920760297dc43b8

commit 7d2b64c5d878d81db824e4ff0920760297dc43b8
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Oct 13 22:35:57 2016

Add UMA for documents calling window.print().

BUG= 631513 

Review-Url: https://codereview.chromium.org/2412753002
Cr-Commit-Position: refs/heads/master@{#424898}
(cherry picked from commit e440d8cb3d9ff035fa588fd0b13b73f3deaa9568)

Review URL: https://codereview.chromium.org/2415953003 .

Cr-Commit-Position: refs/branch-heads/2883@{#99}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/7d2b64c5d878d81db824e4ff0920760297dc43b8/content/renderer/render_view_impl.cc
[modify] https://crrev.com/7d2b64c5d878d81db824e4ff0920760297dc43b8/tools/metrics/histograms/histograms.xml

Comment 25 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818

commit aaa2bba38197c0bcaa7cbcf15281ef4f9d568818
Author: thestig <thestig@chromium.org>
Date: Wed Nov 16 02:06:44 2016

Make printing work better with OOPIF.

BUG= 631513 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2426503002
Cr-Commit-Position: refs/heads/master@{#432353}

[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/android_webview/browser/aw_print_manager.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/android_webview/browser/aw_print_manager.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/android_webview/renderer/aw_print_web_view_helper_delegate.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/android_webview/renderer/aw_print_web_view_helper_delegate.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/android_webview/renderer/print_render_frame_observer.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_preview_message_handler.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_preview_message_handler.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_view_manager.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_view_manager.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/renderer/pepper/chrome_pdf_print_client.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/browser/print_manager.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/browser/print_manager.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/common/print_messages.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/renderer/print_web_view_helper.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/test/print_test_content_renderer_client.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/public/browser/render_frame_host.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/public/renderer/render_frame_observer.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/public/renderer/render_view_observer.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/renderer/render_frame_impl.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/content/renderer/render_view_impl.cc
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/ipc/ipc_message_macros.h
[modify] https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818/ipc/ipc_message_templates.h

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/356feed53225dcf84b0f13c8c2366280be526832

commit 356feed53225dcf84b0f13c8c2366280be526832
Author: sgurun <sgurun@chromium.org>
Date: Wed Nov 16 16:13:06 2016

Revert of Make printing work better with OOPIF. (patchset #17 id:340001 of https://codereview.chromium.org/2426503002/ )

Reason for revert:
webview printing cts test fails.

Original issue's description:
> Make printing work better with OOPIF.
>
> BUG= 631513 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/aaa2bba38197c0bcaa7cbcf15281ef4f9d568818
> Cr-Commit-Position: refs/heads/master@{#432353}

TBR=rockot@chromium.org,lukasza@chromium.org,nasko@chromium.org,thestig@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 631513 

Review-Url: https://codereview.chromium.org/2510753002
Cr-Commit-Position: refs/heads/master@{#432507}

[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/android_webview/browser/aw_print_manager.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/android_webview/browser/aw_print_manager.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/android_webview/renderer/aw_print_web_view_helper_delegate.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/android_webview/renderer/aw_print_web_view_helper_delegate.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/android_webview/renderer/print_render_frame_observer.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_preview_message_handler.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_preview_message_handler.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_view_manager.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_view_manager.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/renderer/pepper/chrome_pdf_print_client.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/browser/print_manager.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/browser/print_manager.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/common/print_messages.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/renderer/print_web_view_helper.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/test/print_test_content_renderer_client.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/public/browser/render_frame_host.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/public/renderer/render_frame_observer.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/public/renderer/render_view_observer.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/renderer/render_frame_impl.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/content/renderer/render_view_impl.cc
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/ipc/ipc_message_macros.h
[modify] https://crrev.com/356feed53225dcf84b0f13c8c2366280be526832/ipc/ipc_message_templates.h

Comment 28 by lukasza@chromium.org, Nov 16 2016

Cc: sgu...@chromium.org

sgurun@, could you please provide more details about "webview printing cts test fails"?  Would you have a link to a test log from a bot that we could take a look at to understand exactly what is failing?

Comment 29 by lukasza@chromium.org, Nov 16 2016

Actually, I think I've found it - I am guessing that we are talking about the test here: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/17958

Comment 30 by sgu...@chromium.org, Nov 16 2016

yes I am trying to repro it locally, follow crbug/665909

Comment 31 by lukasza@chromium.org, Nov 16 2016

Blockedon: 665909

Comment 32 Deleted

Comment 33 by amineer@chromium.org, Nov 16 2016

[Bulk edit]

Branch issues caused these items to be erroneously tagged as merged to branch 2922, please ignore.

Comment 34 by mmoss@chromium.org, Nov 16 2016

Labels: -merge-merged-2922

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb959ce66a9a89b6f100795bb33292439a7ed7de

commit cb959ce66a9a89b6f100795bb33292439a7ed7de
Author: thestig <thestig@chromium.org>
Date: Thu Nov 17 05:56:32 2016

Make printing work better with OOPIF. (try 2)

Fix failing Android WebView CTS tests this time.

BUG= 631513 , 665909 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=nasko@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2508923003
Cr-Commit-Position: refs/heads/master@{#432775}

[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_print_manager.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_print_manager.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_printing_message_filter.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_printing_message_filter.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/aw_print_web_view_helper_delegate.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/aw_print_web_view_helper_delegate.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/print_render_frame_observer.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_message_handler.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_message_handler.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/pepper/chrome_pdf_print_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/browser/print_manager.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/browser/print_manager.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/common/print_messages.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/renderer/print_web_view_helper.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/test/print_test_content_renderer_client.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/public/browser/render_frame_host.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/public/renderer/render_frame_observer.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/public/renderer/render_view_observer.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/renderer/render_frame_impl.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/renderer/render_view_impl.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/ipc/ipc_message_macros.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/ipc/ipc_message_templates.h

Comment 36 by thestig@chromium.org, Nov 17 2016

Status: Fixed (was: Assigned)

►

Issue 631513 link

Issue metadata

Printing from an OOPIF does not work

Issue description

Comment 1 by lukasza@chromium.org, Jul 26 2016

Comment 1 Deleted

Comment 2 by alex...@chromium.org, Oct 6 2016

Comment 2 Deleted

Comment 3 by thestig@chromium.org, Oct 6 2016

Comment 3 Deleted

Comment 4 by thestig@chromium.org, Oct 6 2016

Comment 4 Deleted

Comment 5 by rob@robwu.nl, Oct 7 2016

Comment 5 Deleted

Comment 6 by thestig@chromium.org, Oct 7 2016

Comment 6 Deleted

Comment 7 by alex...@chromium.org, Oct 7 2016

Comment 7 Deleted

Comment 8 by thestig@chromium.org, Oct 7 2016

Comment 8 Deleted

Comment 9 by thestig@chromium.org, Oct 7 2016

Comment 9 Deleted

Comment 10 by nasko@chromium.org, Oct 7 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Oct 12 2016

Comment 11 Deleted

Comment 12 by nasko@chromium.org, Oct 13 2016

Comment 12 Deleted

Comment 13 by dimu@chromium.org, Oct 13 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Oct 13 2016

Comment 14 Deleted

Comment 15 by thestig@chromium.org, Oct 17 2016

Comment 15 Deleted

Comment 16 by rob@robwu.nl, Oct 17 2016

Comment 16 Deleted

Comment 17 by thestig@chromium.org, Oct 18 2016

Comment 17 Deleted

Comment 18 by ranjitkan@chromium.org, Oct 18 2016

Comment 18 Deleted

Comment 19 by creis@chromium.org, Oct 18 2016

Comment 19 Deleted

Comment 20 by creis@chromium.org, Oct 21 2016

Comment 20 Deleted

Comment 21 by nasko@chromium.org, Oct 24 2016

Comment 21 Deleted

Comment 22 by thestig@chromium.org, Oct 24 2016

Comment 22 Deleted

Comment 23 by rob@robwu.nl, Oct 25 2016

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Oct 27 2016

Comment 24 Deleted

Comment 25 by dimu@google.com, Nov 4 2016

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Nov 16 2016

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Nov 16 2016

Comment 27 Deleted

Comment 28 by lukasza@chromium.org, Nov 16 2016

Comment 28 Deleted

Comment 29 by lukasza@chromium.org, Nov 16 2016

Comment 29 Deleted

Comment 30 by sgu...@chromium.org, Nov 16 2016

Comment 30 Deleted

Comment 31 by lukasza@chromium.org, Nov 16 2016

Comment 31 Deleted

Comment 32 Deleted

Comment 33 by amineer@chromium.org, Nov 16 2016

Comment 33 Deleted

Comment 34 by mmoss@chromium.org, Nov 16 2016

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Nov 17 2016

Comment 35 Deleted

Comment 36 by thestig@chromium.org, Nov 17 2016

Comment 36 Deleted

Sign in to add a comment