New issue
Advanced search Search tips

Issue 631501 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

deploy_chrome --mash needs to be fixed

Project Member Reported by sadrul@chromium.org, Jul 26 2016

Issue description

https://codereview.chromium.org/2172673002 changed the location of the mash packages from 'Mojo Applications' to 'Packages'. This broke 'deploy_chrome --mash'.
 
Status: Started (was: Available)
Owner: kylec...@chromium.org
I've sent out the chromite patch for review.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0f4de940b3e766717218ba245efa569250190b33

commit 0f4de940b3e766717218ba245efa569250190b33
Author: kylechar <kylechar@chromium.org>
Date: Tue Jul 26 19:10:53 2016

deploy_chrome: Fix Mojo app directory.

The "Mojo Applications" directory was changed to "Packages" and this breaks
deploy_chrome when used with the --mash option.

BUG= chromium:631501 
TEST=Tested locally deploying mash to a Pixel.

Change-Id: I08c693bfd1319b84b7b4ea6b668df4c0e1c11951
Reviewed-on: https://chromium-review.googlesource.com/363600
Commit-Ready: Kyle Charbonneau <kylechar@chromium.org>
Tested-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0f4de940b3e766717218ba245efa569250190b33/lib/chrome_util.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a6c585c5a6ae79954208952a5e03763332dbf8d

commit 2a6c585c5a6ae79954208952a5e03763332dbf8d
Author: kylechar <kylechar@chromium.org>
Date: Thu Aug 04 13:55:42 2016

Roll src/third_party/chromite/ ef7e437..762cbcda (10 commits)

https://chromium.googlesource.com/chromiumos/chromite/+log/ef7e437..762cbcd

git log ef7e437..762cbcd --date=short --no-merges --format='%ad %ae %s'
2016-07-23 philipchen@google.com Remove bvt-cq in elm-paladin hwtest
2016-08-02 hidehiko@chromium.org Fix GetLatestAndroidVersion().
2016-07-29 lhchavez@google.com Further increase VMTests timeout for telemetry bots
2016-07-29 nxia@chromium.org Insert buildbucket_id into clActionTable
2016-07-26 kylechar@chromium.org deploy_chrome: Fix Mojo app directory.
2016-08-01 nxia@chromium.org Fix waterfall_layout_dump in config-updater.
2016-08-01 chrome-bot@chromium.org Update config settings by config-updater.
2016-08-01 chrome-bot@chromium.org Update config settings by config-updater.
2016-07-07 bhthompson@google.com Add samus and cyan builds for cheets, make all not important
2016-08-01 bhthompson@google.com Add kevin-tpm2 build configs

BUG= 631501 

Review-Url: https://codereview.chromium.org/2209753002
Cr-Commit-Position: refs/heads/master@{#409772}

[modify] https://crrev.com/2a6c585c5a6ae79954208952a5e03763332dbf8d/DEPS

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 9 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment