New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631498 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

maximized mode state does not notify WindowStateObserver when minimized.

Project Member Reported by osh...@chromium.org, Jul 26 2016

Issue description

which is causing an assertion failure in exo/wayland.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 27 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by osh...@chromium.org, Jul 27 2016

Labels: -M-54 -MovedFrom-53 ReleaseBlock-Stable M-53

Comment 4 by osh...@chromium.org, Jul 28 2016

Labels: Merge-Request-53

Comment 5 by dimu@chromium.org, Jul 29 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 29 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd28d911352b50cfc168015094373282cf61b45b

commit cd28d911352b50cfc168015094373282cf61b45b
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Jul 29 13:13:43 2016

Notify WindowStateObserver when minimizing in maximized mode.

BUG= 631498 
TEST=covered by unittest

Review-Url: https://codereview.chromium.org/2182183002
Cr-Commit-Position: refs/heads/master@{#408320}
(cherry picked from commit 2d49e855263fbcbb63b7e6dd153b3240577348e3)

Review URL: https://codereview.chromium.org/2193783003 .

Cr-Commit-Position: refs/branch-heads/2785@{#403}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/cd28d911352b50cfc168015094373282cf61b45b/ash/BUILD.gn
[modify] https://crrev.com/cd28d911352b50cfc168015094373282cf61b45b/ash/common/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/cd28d911352b50cfc168015094373282cf61b45b/ash/common/wm/window_state_observer.h
[modify] https://crrev.com/cd28d911352b50cfc168015094373282cf61b45b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc

Comment 7 by osh...@chromium.org, Jul 29 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment