New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631488 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 2016
Cc:
ajha@chromium.org
█ sungmann...@navercorp.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

The window icon on the windowed inspector is too large

Reported by sungmann...@navercorp.com, Jul 26 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36

Steps to reproduce the problem:
1. Open "Settings" > "Display settings".
2. Adjust the slider under "Change the size of text, apps, and other items" to 150% or 200%.
3. Click the Apply button to reflect changes.
4. Run chrome.exe with "--disable-dwm-composition" switch.
5. Open the inspector in windowed mode.

What is the expected behavior?

What went wrong?
The window icon on the title bar is drawn too big.

Did this work before? N/A 

Chrome version: 52.0.2743.82  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0
Screen Shot 2016-07-26 at 9.56.24 PM.png
603 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9502bad0f8dd68836373a6dfc1eae65f85a6e98a

commit 9502bad0f8dd68836373a6dfc1eae65f85a6e98a
Author: sungmann.cho <sungmann.cho@navercorp.com>
Date: Wed Jul 27 02:20:47 2016

[Win] OBFV::GetIconSize() should return the value in dip unit

OpaqueBrowserFrameView::GetIconSize() returns the size of the window icon. On
Windows, the value is obtained from GetSystemMetrics(SM_CYSMICON) call, but the
problem is that the value returned is in pixel, not in dip. This leads to a
wrong sized window icon if an user is using a higher scale ratio. This CL
replaces GetSystemMetrics() with display::win::GetSystemMetricsInDIP() to fix
this.

BUG= 631488 
TEST=See the bug page for the reproduce steps

Review-Url: https://codereview.chromium.org/2183103002
Cr-Commit-Position: refs/heads/master@{#408017}

[modify] https://crrev.com/9502bad0f8dd68836373a6dfc1eae65f85a6e98a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfff171967e262866054da6ce1e07961fde797e8

commit bfff171967e262866054da6ce1e07961fde797e8
Author: sungmann.cho <sungmann.cho@navercorp.com>
Date: Thu Jul 28 00:21:06 2016

[Win] CustomFrameView::IconSize() should return the value in dip unit

CustomFrameView::IconSize() returns the size of the window icon. On Windows,
the value is obtained from GetSystemMetrics(SM_CYSMICON) call, but the problem
is that the value returned is in pixel, not in dip. This leads to a wrong sized
window icon if an user is using a higher scale ratio. This CL replaces
GetSystemMetrics() with display::win::GetSystemMetricsInDIP() to fix this.

BUG= 631488 
TEST=See the bug page for the reproduce steps

Review-Url: https://codereview.chromium.org/2190593002
Cr-Commit-Position: refs/heads/master@{#408290}

[modify] https://crrev.com/bfff171967e262866054da6ce1e07961fde797e8/ui/views/window/custom_frame_view.cc

Comment 3 by brajkumar@chromium.org, Jul 28 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2810.2
Verified this issue on Windows-7 using chrome latest canary M54-54.0.2810.2 by following steps mentioned in the original comment. Observed the window icon on the title bar is looking normal as expected. Hence adding TE-Verified label.
ChromeIcon.jpg
164 KB View Download

Comment 4 by sungmann...@navercorp.com, Jul 28 2016

Cc: sungmann...@navercorp.com

Comment 5 by ajha@chromium.org, Aug 1 2016

Cc: ajha@chromium.org
Status: Untriaged (was: Unconfirmed)
sungmann.cho@: Please let us know if there is no further work to be done on this.

If not, we will mark the issue as Fixed.

Comment 6 Deleted

Comment 7 by sungmann...@navercorp.com, Aug 1 2016 

ajha@: It has been fixed and there is no further work on this. Thanks!

Comment 8 by ajha@chromium.org, Aug 1 2016

Status: Fixed (was: Untriaged)
Thanks for the update.

Closing as per C#7.
►

Sign in to add a comment