New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631479 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 629015



Sign in to add a comment

Implement the UI exposing a bookmark suggestions section

Project Member Reported by jkrcal@chromium.org, Jul 26 2016

Issue description

After the bookmark suggestion provider is ready, we need a UI to display them on the android NTP.
 

Comment 1 by jkrcal@chromium.org, Jul 26 2016

I might find enough spare cycles to do it myself.

Comment 2 by fi...@chromium.org, Jul 28 2016

Labels: zine-triaged

Comment 3 by fi...@chromium.org, Jul 28 2016

Labels: -Type-Bug Type-Feature

Comment 4 by fi...@chromium.org, Jul 28 2016

Status: Available (was: Untriaged)

Comment 5 by nepper@chromium.org, Jul 29 2016

Labels: M-54

Comment 6 by fi...@chromium.org, Aug 5 2016

Owner: peconn@chromium.org
Status: Assigned (was: Available)
Hi Peter, what's the current status of this? Thanks :)
So I am currently blocked on:
- Bernhard's CL to allow multi-section support on the UI (https://codereview.chromium.org/2196273002/)
- Philipp's CL to add CategoryInfo meta data to categories (https://codereview.chromium.org/2207493002/)

However, these both look they should be done soon and once they are done this change should be fairly simple (in fact Philipp is doing some of the work I had planned on doing).

(I didn't add the bugs for those CLs as blocking since the CLs are just small parts of the overall bugs)
Ok, thanks for the update!
just FYI - the CLs you mentioned in comment #8 have all landed.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ada493805a5a7abc38a38a706ba5db7f627c4db

commit 9ada493805a5a7abc38a38a706ba5db7f627c4db
Author: peconn <peconn@chromium.org>
Date: Fri Aug 12 16:29:32 2016

Change Snippet layout based on Category.

BUG=634275,  631479 

Review-Url: https://codereview.chromium.org/2235463002
Cr-Commit-Position: refs/heads/master@{#411671}

[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/UiConfig.java
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleListItem.java
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/browser/android/ntp/ntp_snippets_bridge.cc

Labels: zine-16-08-08
Status: Started (was: Assigned)
Labels: zine-16-08-15
Status: Fixed (was: Started)

Sign in to add a comment