Implement the UI exposing a bookmark suggestions section |
|||||||||
Issue descriptionAfter the bookmark suggestion provider is ready, we need a UI to display them on the android NTP.
,
Jul 28 2016
,
Jul 28 2016
,
Jul 28 2016
,
Jul 29 2016
,
Aug 5 2016
,
Aug 5 2016
Hi Peter, what's the current status of this? Thanks :)
,
Aug 5 2016
So I am currently blocked on: - Bernhard's CL to allow multi-section support on the UI (https://codereview.chromium.org/2196273002/) - Philipp's CL to add CategoryInfo meta data to categories (https://codereview.chromium.org/2207493002/) However, these both look they should be done soon and once they are done this change should be fairly simple (in fact Philipp is doing some of the work I had planned on doing). (I didn't add the bugs for those CLs as blocking since the CLs are just small parts of the overall bugs)
,
Aug 5 2016
Ok, thanks for the update!
,
Aug 9 2016
just FYI - the CLs you mentioned in comment #8 have all landed.
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ada493805a5a7abc38a38a706ba5db7f627c4db commit 9ada493805a5a7abc38a38a706ba5db7f627c4db Author: peconn <peconn@chromium.org> Date: Fri Aug 12 16:29:32 2016 Change Snippet layout based on Category. BUG=634275, 631479 Review-Url: https://codereview.chromium.org/2235463002 Cr-Commit-Position: refs/heads/master@{#411671} [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/res/layout/new_tab_page_snippets_card.xml [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/UiConfig.java [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleListItem.java [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/9ada493805a5a7abc38a38a706ba5db7f627c4db/chrome/browser/android/ntp/ntp_snippets_bridge.cc
,
Aug 15 2016
,
Aug 15 2016
,
Aug 16 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jkrcal@chromium.org
, Jul 26 2016