Use MediaRecorder to capture video for quality test. |
||
Issue descriptionUse MediaRecorder to capture video for quality test. Retrite the WebRTC video quality test to use the MediaRecorder API instead of recording from a canvas.
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/668a1e44390e683f82f24a5318946bf0889cffe1 commit 668a1e44390e683f82f24a5318946bf0889cffe1 Author: kjellander <kjellander@chromium.org> Date: Mon Aug 01 06:49:42 2016 Revert of Use MediaRecorder to capture video for quality test. (patchset #1 id:1 of https://codereview.chromium.org/2183873002/ ) Reason for revert: Performance numbers regressed a bit too much after landing this, example: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxozpqQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICght-9qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxuK2sgkM Original issue's description: > Use MediaRecorder to capture video for quality test. > > Retrite the WebRTC video quality test to use the MediaRecorder API > instead of recording from a canvas. > > BUG= 631458 > > Committed: https://crrev.com/0204f3d64d8472a25d93312356d2a1c4acbb600e > Cr-Commit-Position: refs/heads/master@{#408633} TBR=phoglund@chromium.org,mcasas@chromium.org,ehmaldonado@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 631458 Review-Url: https://codereview.chromium.org/2199653002 Cr-Commit-Position: refs/heads/master@{#408919} [modify] https://crrev.com/668a1e44390e683f82f24a5318946bf0889cffe1/chrome/browser/media/webrtc_video_quality_browsertest.cc [modify] https://crrev.com/668a1e44390e683f82f24a5318946bf0889cffe1/chrome/test/data/webrtc/video_extraction.js [modify] https://crrev.com/668a1e44390e683f82f24a5318946bf0889cffe1/chrome/test/data/webrtc/webrtc_video_quality_test.html
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62aca783c8e834c40bbade6e2076c583e9b51d61 commit 62aca783c8e834c40bbade6e2076c583e9b51d61 Author: ehmaldonado <ehmaldonado@chromium.org> Date: Thu Aug 04 12:08:27 2016 Reland of Use MediaRecorder to capture video for quality test. (patchset #1 id:1 of https://codereview.chromium.org/2183873002/ ) The original CL caused a big regression after landing, as can be seen for example in https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxozpqQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICght-9qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxuK2sgkM I now tell ffmpeg the desired resolution for the output file, which should prevent causing such a big regression. Also removed unused Firefox case in getStreamFromElement_ function. Original issue's description: > Use MediaRecorder to capture video for quality test. > > Retrite the WebRTC video quality test to use the MediaRecorder API > instead of recording from a canvas. BUG= 631458 TBR=phoglund@chromium.org Review-Url: https://codereview.chromium.org/2199373002 Cr-Commit-Position: refs/heads/master@{#409765} [modify] https://crrev.com/62aca783c8e834c40bbade6e2076c583e9b51d61/chrome/browser/media/webrtc_video_quality_browsertest.cc [modify] https://crrev.com/62aca783c8e834c40bbade6e2076c583e9b51d61/chrome/test/data/webrtc/video_extraction.js [modify] https://crrev.com/62aca783c8e834c40bbade6e2076c583e9b51d61/chrome/test/data/webrtc/webrtc_video_quality_test.html
,
Aug 8 2016
I guess we can close this as fixed or do we have any remaining work?
,
Aug 8 2016
Yeah, I think we can close this. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 29 2016