New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631442 link

Starred by 2 users
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Jul 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Allow registering variation IDs from feature variations in chrome://flags

Project Member Reported by jkrcal@chromium.org, Jul 26 2016 
The UI in chrome://flags allows to choose among a predefined set of feature variations. These variations cannot come with a variation ID at the moment.

We need to have this for experiments with Chrome NTP on Android.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf07337daa7e3f20fcb1839f300baab6f1df3f35

commit bf07337daa7e3f20fcb1839f300baab6f1df3f35
Author: jkrcal <jkrcal@chromium.org>
Date: Fri Jul 29 07:21:31 2016

Add other variations (with ids) for NTPSnippets to chrome://flags

This CL allows to specify variation ids for variations defined for
chrome://flags. The CL also extends the list of variations for the
NTPSnippets feature (some of the variations specify a variation id).

This issue also updates the iOS code to achieve feature parity w.r.t. issues 2036193002 and 2129543002.

BUG= 631442 

Review-Url: https://codereview.chromium.org/2182553002
Cr-Commit-Position: refs/heads/master@{#408599}

[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/chrome/browser/about_flags.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/chrome/browser/about_flags.h
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/flags_ui/feature_entry.h
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/flags_ui/flags_state.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/flags_ui/flags_state.h
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/flags_ui/flags_state_unittest.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/variations/variations_associated_data.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/variations/variations_associated_data.h
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/variations/variations_http_header_provider.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/variations/variations_http_header_provider.h
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/components/variations/variations_http_header_provider_unittest.cc
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/ios/chrome/browser/about_flags.h
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/bf07337daa7e3f20fcb1839f300baab6f1df3f35/ios/chrome/browser/ios_chrome_main_parts.mm

Comment 2 by jkrcal@chromium.org, Jul 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment