New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631428 link

Starred by 4 users
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
esprehn@chromium.org
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Traces of plugin block overlay is seen after toggling to fullscreen mode.

Reported by vku...@etouch.net, Jul 26 2016 
Chrome Version: 54.0.2808.0 (Official Build)Revision 96ce8347f39ce0eebd10de476afb08c0afb406c9-refs/heads/master@{#407658} (32/64-bit)
OS: Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://settings/content , click on "let me choose when to run.." option under Plugin section.
(2)Navigate to http://www.vudu.com/ click on any video and resize window from R.H.S
(3)Now click on fullscreen icon via wrench menu, observe.

Actual: Traces of plugin block overlay is seen after toggling to fullscreen mode.

Expected: Traces of plugin block overlay should not be seen after toggling to fullscreen mode.

This is a regression issue broken in 'M54' and will soon update other info.

Comment 1 by vku...@etouch.net, Jul 26 2016

Cc: tommycli@chromium.org
Labels: hasbisect
Owner: dcasta...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 54.0.2803.0
Bad Build:  54.0.2804.0

CL:
https://chromium.googlesource.com/chromium/src/+log/54.0.2803.0..54.0.2804.0?pretty=fuller&n=10000
(Unable to narrow down the range using tool)

Suspecting: 406952 or 406908 ?

Note: Above issue is seen for all overlay like 'select profile photo' etc after blocking plugin.
Actual.png
345 KB View Download
Actual_Plugins.mp4
398 KB View Download
Expected_Plugins.mp4
381 KB View Download

Comment 2 by msrchandra@chromium.org, Jul 26 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by dcasta...@chromium.org, Jul 26 2016

Owner: tommycli@chromium.org
crrev.com/406952 doesn't really changed anything unless someone was already passing the flag enable-hardware-overlays=single-fullscreen before it was introduced with that CL.

Reassinging to tommycli@.

Comment 4 by ajha@chromium.org, Jul 29 2016 

tommycli@: Could you please take a look and confirm if this is related to https://codereview.chromium.org/2164753003

Comment 5 by ajha@chromium.org, Aug 3 2016

Cc: -tommycli@chromium.org esprehn@chromium.org
Still reproducible on the latest canary(54.0.2816.4) on Mac OS 10.11.5.

Friendly ping to get an update on this issue.

Comment 6 by tommycli@chromium.org, Aug 3 2016 

ajha: Thanks for the ping. Sorry I've been lagging on this issue. I'll take a look this morning.

Comment 7 by tommycli@chromium.org, Aug 3 2016

Cc: dcheng@chromium.org
I can confirm that the above patch caused this behavior.

dcheng/esprehn: Any idea why posting the geometry updates entirely to a task causes these visual artifacts?

This patch fixes the artifacts: https://codereview.chromium.org/2205693007
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d02278211e46de5b07ac2cdaf26eecc3bf224bb

commit 7d02278211e46de5b07ac2cdaf26eecc3bf224bb
Author: tommycli <tommycli@chromium.org>
Date: Thu Aug 04 02:43:24 2016

WebViewPlugin: Make WebView resize take place synchronously.

Previously, we committed https://codereview.chromium.org/2164753003 to
fix a crash. That patch made geometry-triggered updates asynchronous.

However, this leads to visual artifacts. This CL makes some of those
operations synchronous again, but should leave the crashy parts still
async.

BUG= 631428 

Review-Url: https://codereview.chromium.org/2205693007
Cr-Commit-Position: refs/heads/master@{#409709}

[modify] https://crrev.com/7d02278211e46de5b07ac2cdaf26eecc3bf224bb/components/plugins/renderer/webview_plugin.cc

Comment 9 by tommycli@chromium.org, Aug 5 2016

Labels: Merge-Request-53
Needs a merge to 53.

Comment 10 by dimu@chromium.org, Aug 5 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 5 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/501e16d2ff332db2b65240935eec936dab69a02b

commit 501e16d2ff332db2b65240935eec936dab69a02b
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Aug 05 17:10:52 2016

WebViewPlugin: Make WebView resize take place synchronously.

Previously, we committed https://codereview.chromium.org/2164753003 to
fix a crash. That patch made geometry-triggered updates asynchronous.

However, this leads to visual artifacts. This CL makes some of those
operations synchronous again, but should leave the crashy parts still
async.

BUG= 631428 

Review-Url: https://codereview.chromium.org/2205693007
Cr-Commit-Position: refs/heads/master@{#409709}
(cherry picked from commit 7d02278211e46de5b07ac2cdaf26eecc3bf224bb)

Review URL: https://codereview.chromium.org/2211263003 .

Cr-Commit-Position: refs/branch-heads/2785@{#511}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/501e16d2ff332db2b65240935eec936dab69a02b/components/plugins/renderer/webview_plugin.cc

Comment 12 by tommycli@chromium.org, Aug 5 2016

Status: Fixed (was: Assigned)

Comment 13 by kavvaru@chromium.org, Aug 9 2016

Labels: TE-Verified-54.0.2823.0 TE-Verified-M54 TE-Verified-54.0.2824.0
Tested the issue on windows 7, Mac 10.11.6 using chrome version 54.0.2824.0.Not observed any traces of plugin overlay after toggling to full screen.Please find the attached screen cast for the same.
Verified the same on Linux using chrome version 54.0.2823.0 as the linux build failure due to issue 635768.

Adding TE-Verified labels.

Thanks,
631428.mp4
799 KB View Download

Comment 14 by kavvaru@chromium.org, Aug 10 2016

Labels: TE-Verified-53.0.2785.57 TE-Verified-M53
Verified the issue on windows 7,Linux Ubuntu 14.04 and  Mac 10.11.6 using chrome version 53.0.2785.57.fix is working fine not observed any traces of plugin.please find the attached screen cast for the same.

Adding TE-Verified labels.
631428.mp4
1.4 MB View Download
►

Sign in to add a comment