New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631426 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in page_cycler.top_10_mobile at 406556:406591

Project Member Reported by primiano@chromium.org, Jul 26 2016

Issue description

ha memory regression. Let's see if the bisect can find it wihtout me digging into the metric.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=631426

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICguqSHowkM


Bot(s) for this bug's original alert(s):

android-nexus9
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 26 2016

Cc: huape...@amazon.com
Owner: huape...@amazon.com

=== Auto-CCing suspected CL author huapengl@amazon.com ===

Hi huapengl@amazon.com, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Use "-Os" for Android or IOS in "optimize_max" config (patchset #1 id:1 of https://codereview.chromium.org/2158053002/ )
Author  : huapengl
Commit description:
  
Reason for revert:
8.1% regression in speedometer at 406285:406306

https://bugs.chromium.org/p/chromium/issues/detail?id=629798#c4

Original issue's description:
> Use "-Os" for Android or IOS in "optimize_max" config
>
> Using "-Os" would benefit both Android and IOS build, because "-Os" does
> "-O2" optimizations and code size improvement.
>
> libchrome.so drops from 44MB to 42 MB.
> ChromePublic.apk drops from 47 MB to 45 MB.
>
> BUG=621335
>
> Committed: https://crrev.com/2bb3c4f7a7c7632afe1b63a19d49daa61bbfc37b
> Cr-Commit-Position: refs/heads/master@{#406304}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=621335

Review-Url: https://codereview.chromium.org/2164973002
Cr-Commit-Position: refs/heads/master@{#406569}
Commit  : 8f5987c15bd03c5da97aa27103d36c5943e78259
Date    : Wed Jul 20 16:10:33 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@406555  154309  703.289  8  good
chromium@406564  154522  708.299  8  good
chromium@406567  154055  718.541  8  good
chromium@406568  154416  792.991  5  good
chromium@406569  156257  693.134  8  bad    <--
chromium@406573  155967  662.229  5  bad
chromium@406591  156375  744.804  8  bad

Bisect job ran on: android_nexus9_perf_bisect
Bug ID: 631426

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.top_10_mobile
Test Metric: vm_proportional_set_size_final_total/vm_proportional_set_size_final_total
Relative Change: 1.13%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/1922
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006079765871018816


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5743635996344320

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 27 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Use "-Os" for Android or IOS in "optimize_max" config (patchset #1 id:1 of https://codereview.chromium.org/2158053002/ )
Author  : huapengl
Commit description:
  
Reason for revert:
8.1% regression in speedometer at 406285:406306

https://bugs.chromium.org/p/chromium/issues/detail?id=629798#c4

Original issue's description:
> Use "-Os" for Android or IOS in "optimize_max" config
>
> Using "-Os" would benefit both Android and IOS build, because "-Os" does
> "-O2" optimizations and code size improvement.
>
> libchrome.so drops from 44MB to 42 MB.
> ChromePublic.apk drops from 47 MB to 45 MB.
>
> BUG=621335
>
> Committed: https://crrev.com/2bb3c4f7a7c7632afe1b63a19d49daa61bbfc37b
> Cr-Commit-Position: refs/heads/master@{#406304}

TBR=dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=621335

Review-Url: https://codereview.chromium.org/2164973002
Cr-Commit-Position: refs/heads/master@{#406569}
Commit  : 8f5987c15bd03c5da97aa27103d36c5943e78259
Date    : Wed Jul 20 16:10:33 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@406555  146472  905.48   8  good
chromium@406564  146886  800.698  8  good
chromium@406567  147010  1066.82  8  good
chromium@406568  147084  346.352  5  good
chromium@406569  149091  1117.64  8  bad    <--
chromium@406573  148897  871.456  5  bad
chromium@406591  149358  843.508  8  bad

Bisect job ran on: android_nexus9_perf_bisect
Bug ID: 631426

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.top_10_mobile
Test Metric: vm_proportional_set_size_final_total/http___www.baidu.com_s?word_google
Relative Change: 1.81%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/1923
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006079736540843392


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5772963241000960

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Fixed (was: Assigned)
Revert of recent change, closing out.

Sign in to add a comment