New issue
Advanced search Search tips

Issue 631420 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 631068
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.3% regression in top_10_mobile_memory at 406232:406252

Project Member Reported by primiano@chromium.org, Jul 26 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=631420

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg-qWGvgoM


Bot(s) for this bug's original alert(s):

android-nexus7v2
Cc: bmeu...@chromium.org
Given that this is a regression in the v8 metric (memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_avg) and the CL in range  of the two rolls (https://chromium.googlesource.com/v8/v8/+log/9b382ab2..7a5e2fcd), I believe the only candidates are:

- esiginer's: https://codereview.chromium.org/2156153002
- bmeurer's: https://codereview.chromium.org/2161943002
- bmeurer's: https://codereview.chromium.org/2151163002
(The first one looks a non-functional refactor to me but dunno)
The other CLs in range seem MIPS or ia32-related to me.


Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 26 2016

Mergedinto: 631068
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Remove duplication of encoded image data
Author  : hajimehoshi
Commit description:
  
Now there are at least two encoded image data: one is in Image/ImageResource as
SharedBuffer and the other is in DeferredImageDecoder as SkRWBuffer. This CL
removes former when possible (non-icon bitmaps), and generate the SharedBuffer
from the SkRWBuffer if needed.

Design Doc: https://docs.google.com/document/d/1v0yTAZ6wkqX2U_M6BNIGUJpM1s0TIw1VsqpxoL7aciY/edit?usp=sharing

BUG= 618623 
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*:ImageDecoderTest.*

Review-Url: https://codereview.chromium.org/2054643003
Cr-Commit-Position: refs/heads/master@{#406238}
Commit  : 36f4eb81d4a791a8e3dfea4ba2418465d30bcc90
Date    : Tue Jul 19 10:02:08 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@406231  5373122  159235   12  good
chromium@406237  5297962  27087.2  5   good
chromium@406238  5604386  230724   5   bad    <--
chromium@406239  5731915  131997   5   bad
chromium@406240  5706261  161945   5   bad
chromium@406242  5811075  243451   5   bad
chromium@406252  5626523  266497   12  bad

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 631420

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests top_10_mobile_memory
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_avg/http___en.m.wikipedia.org_wiki_Science
Relative Change: 0.95%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3097
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006080691539061824


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5079423666094080

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment