New issue
Advanced search Search tips

Issue 631419 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 631041
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.1% regression in thread_times.key_idle_power_cases at 407218:407324

Project Member Reported by primiano@chromium.org, Jul 26 2016

Issue description

Very likely a dupe of  Issue 631418 
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=631419

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgusaxsQoM


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 26 2016

Mergedinto: 631041
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Support early associated interface binding on ChannelMojo
Author  : rockot
Commit description:
  
Changes the associated bindings implementation for ChannelMojo
such that remote interfaces can be acquired immediately upon
ChannelMojo construction rather than having to wait for connection
on the IO thread.

Simplifies the Channel bootstrapping process, removing a round-trip
Init message (and in fact the entire IPC::mojom::Boostrap interface)
since there's no need to actually exchange associated interface handles
over the pipe. Instead both sides can assume the other will use a fixed,
reserved endpoint ID for their IPC::mojom::Channel interface.

This also removes the restriction that associated interfaces must be
added to a Channel after Init. Instead the same constraints apply as
with AddFilter: an associated interface, like a filter, may be added
at any time as long as either Init hasn't been called OR the remote
process hasn't been launched.

The result of this CL is that any place it's safe to AddFilter,
it's also safe to AddAssociatedInterface; and any place it's safe to
Send, it's also safe to GetRemoteAssociatedInterface and begin using
any such remote interface immediately.

Remote interface requests as well as all messages to remote interfaces
retain FIFO with respect to any Send calls on the same thread. Local
interface request dispatch as well as all messages on locally bound
associated interfaces retain FIFO with respect to any OnMessageReceived
calls on the same thread.

BUG=612500, 619202 

Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091
Committed: https://crrev.com/508da24622f957a01b076ccd058bfdccc79068a4
Review-Url: https://codereview.chromium.org/2163633003
Cr-Original-Original-Commit-Position: refs/heads/master@{#406720}
Cr-Original-Commit-Position: refs/heads/master@{#407050}
Cr-Commit-Position: refs/heads/master@{#407264}
Commit  : 0e4de5f9a519c6cd206448a10eccc7a535e3db64
Date    : Fri Jul 22 21:20:12 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@407217  1849.69  4.20271   5  good
chromium@407244  1852.03  2.24599   5  good
chromium@407258  1854.09  0.851026  5  good
chromium@407262  1854.07  1.41888   5  good
chromium@407263  1854.5   3.79536   5  good
chromium@407264  1972.55  1.46469   5  bad    <--
chromium@407265  1972.59  3.37174   5  bad
chromium@407271  1969.1   4.14749   5  bad
chromium@407324  1965.47  1.9735    5  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 631419

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: tasks_per_second_total_all/css-animation.html
Relative Change: 6.26%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2339
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006080906386939344


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5112290030911488

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 29 2016


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@407217  1846.68  4.27847  5  good
chromium@407324  1961.93  1.75979  5  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 631419

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: tasks_per_second_total_all/css-animation.html
Relative Change: 6.24%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2340
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006080913619547488


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5422486796107776

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jul 29 2016


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@407217  1846.68  4.27847  5  good
chromium@407324  1961.93  1.75979  5  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 631419

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: tasks_per_second_total_all/css-animation.html
Relative Change: 6.24%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2340
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006080913619547488


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5422486796107776

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment