Issue metadata
Sign in to add a comment
|
11.9% regression in blink_perf.pywebsocket at 407332:407354 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 26 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006082024057142080
,
Jul 26 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006082018294149280
,
Jul 26 2016
=== Auto-CCing suspected CL author yzshen@chromium.org === Hi yzshen@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types Author : yzshen Commit description: BUG= 624136 Review-Url: https://codereview.chromium.org/2181443002 Cr-Commit-Position: refs/heads/master@{#407340} Commit : 9d5c6a8af5e8298269dc0edf38831a8360be3c7b Date : Sat Jul 23 03:40:41 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@407331 172.2 6.89928 5 good chromium@407337 177.78 7.05457 5 good chromium@407339 178.72 2.23092 5 good chromium@407340 199.12 3.43249 5 bad <-- chromium@407343 198.38 4.02765 5 bad chromium@407354 194.6 1.46287 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 631415 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.pywebsocket Test Metric: fetch-send-arraybuffer-worker-async-verify/fetch-send-arraybuffer-worker-async-verify Relative Change: 13.01% Score: 99.8 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2228 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006082018294149280 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5867676958720000 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 26 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types Author : yzshen Commit description: BUG= 624136 Review-Url: https://codereview.chromium.org/2181443002 Cr-Commit-Position: refs/heads/master@{#407340} Commit : 9d5c6a8af5e8298269dc0edf38831a8360be3c7b Date : Sat Jul 23 03:40:41 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@407331 173.02 3.66838 5 good chromium@407337 176.74 1.8743 5 good chromium@407339 178.96 1.51427 5 good chromium@407340 199.2 1.10454 5 bad <-- chromium@407343 194.22 3.92645 5 bad chromium@407354 194.6 2.02114 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 631415 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.pywebsocket Test Metric: fetch-send-arraybuffer-worker-async-verify/fetch-send-arraybuffer-worker-async-verify Relative Change: 12.47% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2229 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006082024057142080 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5905495194337280 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 26 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006037258924656208
,
Jul 26 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types Author : yzshen Commit description: BUG= 624136 Review-Url: https://codereview.chromium.org/2181443002 Cr-Commit-Position: refs/heads/master@{#407340} Commit : 9d5c6a8af5e8298269dc0edf38831a8360be3c7b Date : Sat Jul 23 03:40:41 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@407331 174.32 3.88742 5 good chromium@407337 177.86 2.56768 5 good chromium@407339 179.48 3.07034 5 good chromium@407340 200.92 9.26537 5 bad <-- chromium@407343 197.4 2.64386 5 bad chromium@407354 195.62 1.89921 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 631415 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.pywebsocket Test Metric: fetch-send-arraybuffer-worker-async-verify/fetch-send-arraybuffer-worker-async-verify Relative Change: 12.22% Score: 99.0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2238 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006037258924656208 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=6410308873093120 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/887252e6ab811d0cc047e3e32f033307215e11d3 commit 887252e6ab811d0cc047e3e32f033307215e11d3 Author: yzshen <yzshen@chromium.org> Date: Fri Jul 29 15:45:29 2016 Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types BUG= 624136 , 631415 Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b Review-Url: https://codereview.chromium.org/2181443002 Cr-Original-Commit-Position: refs/heads/master@{#407340} Cr-Commit-Position: refs/heads/master@{#408644} [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/BUILD.gn [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/ipc.gyp [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/ipc_channel_mojo.cc [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/ipc_channel_mojo.h [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/ipc_message_pipe_reader.cc [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/ipc/ipc_message_pipe_reader.h [modify] https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3/mojo/public/cpp/bindings/array_traits_stl.h
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/247f0e9a24742981c8fc213f526253fbdef8955f commit 247f0e9a24742981c8fc213f526253fbdef8955f Author: benwells <benwells@chromium.org> Date: Mon Aug 01 05:36:47 2016 Revert of Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types (patchset #3 id:40001 of https://codereview.chromium.org/2181443002/ ) Reason for revert: This patch has broken compiling on the MSan bots. Due to memory waterfall shenanigans I haven't had time to investigate why, but I do know that locally reverting this change fixed compile. Sample failure output: FAILED: obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DMEMORY_SANITIZER -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=274369-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -O2 -fno-ident -fdata-sections -ffunction-sections -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -gline-tables-only -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins=2 -fsanitize-blacklist=../../tools/msan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc -o obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o In file included from gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc:15: In file included from gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.h:37: In file included from gen/mojo/public/interfaces/bindings/tests/rect.mojom-blink.h:37: In file included from ../../mojo/public/cpp/bindings/wtf_array.h:15: In file included from ../../mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h:13: ../../third_party/WebKit/Source/wtf/Vector.h:196:32: error: call to deleted constructor of 'mojo::ScopedHandleBase<mojo::Handle>' new (NotNull, dst) T(*src); ^ ~~~~ ../../third_party/WebKit/Source/wtf/Vector.h:323:62: note: in instantiation of function template specialization 'WTF::VectorCopier<false, mojo::ScopedHandleBase<mojo::Handle> >::uninitializedCopy<mojo::ScopedHandleBase<mojo::Handle> >' requested here VectorCopier<VectorTraits<T>::canCopyWithMemcpy, T>::uninitializedCopy(src, srcEnd, dst); ^ ../../third_party/WebKit/Source/wtf/Vector.h:1004:21: note: in instantiation of member function 'WTF::VectorTypeOperations<mojo::ScopedHandleBase<mojo::Handle> >::uninitializedCopy' requested here TypeOperations::uninitializedCopy(other.begin(), other.end(), begin()); ^ ../../buildtools/third_party/libc++/trunk/include/memory:1740:31: note: in instantiation of member function 'WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>::Vector' requested here ::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...); ^ .... snip TBR=rockot@chromium.org,yzshen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. NOPRESUBMIT=true BUG= 624136 , 631415 Review-Url: https://codereview.chromium.org/2199623002 Cr-Commit-Position: refs/heads/master@{#408913} [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/BUILD.gn [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/ipc.gyp [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/ipc_channel_mojo.cc [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/ipc_channel_mojo.h [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/ipc_message_pipe_reader.cc [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/ipc/ipc_message_pipe_reader.h [modify] https://crrev.com/247f0e9a24742981c8fc213f526253fbdef8955f/mojo/public/cpp/bindings/array_traits_stl.h
,
Aug 18 2016
Perf sheriff ping: reminder to follow up on possible performance issues
,
Aug 18 2016
The CL caused the issue has been reverted.
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24b40a317881cf6e23baeafb79fdbb277ed58940 commit 24b40a317881cf6e23baeafb79fdbb277ed58940 Author: yzshen <yzshen@chromium.org> Date: Wed Aug 24 01:10:13 2016 Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types BUG= 624136 , 631415 Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3 Review-Url: https://codereview.chromium.org/2181443002 Cr-Original-Original-Commit-Position: refs/heads/master@{#407340} Cr-Original-Commit-Position: refs/heads/master@{#408644} Cr-Commit-Position: refs/heads/master@{#413921} [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/ipc/BUILD.gn [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/ipc/ipc.gyp [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/ipc/ipc_channel_mojo.cc [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/ipc/ipc_channel_mojo.h [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/ipc/ipc_message_pipe_reader.cc [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/ipc/ipc_message_pipe_reader.h [modify] https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940/mojo/public/cpp/bindings/array_traits_stl.h |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by primiano@chromium.org
, Jul 26 2016