Issue metadata
Sign in to add a comment
|
168.5% regression in blink_perf.layout at 407163:407185 |
||||||||||||||||||||
Issue descriptionI suspect this is again 64a2d4d Fix infinite recursion crash in HarfBuzz' CoreText backend
,
Jul 26 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006082086916827536
,
Jul 26 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Fix infinite recursion crash in HarfBuzz' CoreText backend Author : drott Commit description: The font cascade reconfiguration which was introduced as fix for AAT shaping performance regressions in crbug.com/547912 seems to occasionally cause CoreText crashes on OS X 10.9. We don't have a better way of detecting this than by OS or CoreText API version number. This is one of our top Mac crashers on Mac OS 10.9 with Chrome across versions [1]. This crash does not occur in newer versions of OS X and we can keep this important performance optimization enabled there. A big thanks to Robert Sesek (rsesek@) for the patient and thorough initial investigation. Discussing and working together on this issue we were able to identify the crash triggering code in HarfBuzz in this case. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=576941#c74 BUG= 576941 , 625902 Review-Url: https://codereview.chromium.org/2173883002 Cr-Commit-Position: refs/heads/master@{#407185} Commit : 64a2d4d02ea769c849df4718d196df12a3f79091 Date : Fri Jul 22 17:18:48 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@407162 544.998 43.1477 5 good chromium@407174 543.132 32.7054 5 good chromium@407180 543.213 37.1262 5 good chromium@407183 550.511 34.0498 5 good chromium@407184 546.659 31.1043 5 good chromium@407185 1584.36 49.4606 5 bad <-- Bisect job ran on: mac_retina_perf_bisect Bug ID: 631414 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout Test Metric: character_fallback/character_fallback Relative Change: 190.71% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1444 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006082086916827536 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5006574511194112 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by primiano@chromium.org
, Jul 26 2016