Issue metadata
Sign in to add a comment
|
2.4% regression in thread_times.key_idle_power_cases at 407023:407120 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 26 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006082283228128624
,
Jul 26 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9006082275742540688
,
Jul 26 2016
=== Auto-CCing suspected CL author hpayer@chromium.org === Hi hpayer@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [heap] Remove black pages and use black areas instead. Author : hpayer Commit description: BUG= 630386 LOG=n Review-Url: https://codereview.chromium.org/2160613002 Cr-Commit-Position: refs/heads/master@{#37967} Commit : b008a0d5a3db80a854cb93d9c94d67bf2d780f2c Date : Fri Jul 22 07:02:24 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@407022 0.394948 0.0282437 8 good chromium@407071 0.404374 0.00145426 5 good chromium@407096 0.402117 0.00193808 5 good chromium@407108 0.4021 0.0012943 5 good chromium@407114 0.401659 0.00194571 5 good chromium@407117 0.404409 0.0012944 5 good chromium@407117,v8@6d0a420298 0.403225 0.00334419 5 good chromium@407117,v8@b008a0d5a3 0.412764 0.00145756 5 bad <-- chromium@407118 0.412602 0.00121418 5 bad chromium@407119 0.412735 0.00202057 5 bad chromium@407120 0.409647 0.00161652 8 bad Bisect job ran on: android_one_perf_bisect Bug ID: 631412 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases Test Metric: thread_total_all_cpu_time_per_second/request-animation-frame.html Relative Change: 5.33% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1436 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006082283228128624 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=4890165932195840 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 26 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [heap] Remove black pages and use black areas instead. Author : hpayer Commit description: BUG= 630386 LOG=n Review-Url: https://codereview.chromium.org/2160613002 Cr-Commit-Position: refs/heads/master@{#37967} Commit : b008a0d5a3db80a854cb93d9c94d67bf2d780f2c Date : Fri Jul 22 07:02:24 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@407022 0.330534 0.00356058 8 good chromium@407071 0.339739 0.0247049 8 good chromium@407096 0.331074 0.00197747 5 good chromium@407108 0.331466 0.00236089 5 good chromium@407114 0.330539 0.000988127 5 good chromium@407117 0.330923 0.000791296 5 good chromium@407117,v8@6d0a420298 0.332128 0.00257037 5 good chromium@407117,v8@b008a0d5a3 0.341246 0.00133647 5 bad <-- chromium@407118 0.342456 0.00412166 5 bad chromium@407119 0.341057 0.000756938 5 bad chromium@407120 0.341144 0.00280637 8 bad Bisect job ran on: android_one_perf_bisect Bug ID: 631412 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases Test Metric: thread_total_all_cpu_time_per_second/request-animation-frame.html Relative Change: 2.93% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1437 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006082275742540688 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5873631368839168 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 27 2016
You see? I told you in the past: every time you label a CL "black allocation" or "black pages" it causes a regression. It's all about the name invoking too much black magic. Try to rename them to "unreachable pages" next time :P
,
Jul 28 2016
:-) Interesting. I had to revert the CL due to some crashes. Let's see if it regresses again when I have to reland, maybe using a different color name ;-) |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by primiano@chromium.org
, Jul 26 2016