New issue
Advanced search Search tips

Issue 631393 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

20% regression in dromaeo.domcorequery at 407375:407375

Project Member Reported by primiano@chromium.org, Jul 26 2016

Issue description

No need to bisect here, there is only one CL in the range:

https://codereview.chromium.org/2159633002


 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=631393

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg2uHrqQsM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 26 2016

Cc: dgozman@chromium.org

=== Auto-CCing suspected CL author dgozman@chromium.org ===

Hi dgozman@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.
Author  : dgozman
Commit description:
  
This includes RemoteObject, StackTrace and SearchMatch. Each API class has toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG= 580337 

Review-Url: https://codereview.chromium.org/2159633002
Cr-Commit-Position: refs/heads/master@{#407375}
Commit  : 4e19044900929958a03fc2d5c07cb2cc5aab47ff
Date    : Sat Jul 23 21:46:16 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@407374  5295.51  115.636  5  good
chromium@407375  4612.23  155.879  5  bad    <--

Bisect job ran on: android_s5_perf_bisect
Bug ID: 631393

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests dromaeo.domcorequery
Test Metric: dom/dom
Relative Change: 12.90%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/830
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006085073288151872


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5338703258451968

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
This is really strange - my patch has nothing to do with DOM.
Also note that graphs recovered soon after the regression, staying in (very flaky) range of 5000-6000 as before.
Status: WontFix (was: Assigned)
Alert recovered. No idea what happened.

Sign in to add a comment