New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631391 link

Starred by 2 users
Status: WontFix
Owner:
█ sashab@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
█ sashab@chromium.org
mtklein@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.3% regression in blink_perf.layout at 406391:406477

Project Member Reported by primiano@chromium.org, Jul 26 2016 
See the link to graphs below.

Comment 1 by primiano@chromium.org, Jul 26 2016 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=631391

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg2svI7AsM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 26 2016 


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@406390  135.56   5.34967  12  good
chromium@406477  130.192  9.76559  12  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 631391

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout
Test Metric: auto-grid-lots-of-data/auto-grid-lots-of-data
Relative Change: 4.43%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/829
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006085154552649872


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4512879294808064

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 27 2016

Cc: mtklein@chromium.org
Owner: mtklein@chromium.org

=== Auto-CCing suspected CL author mtklein@chromium.org ===

Hi mtklein@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Fix color order on LCD text when using sRGB software backend.
Author  : mtklein
Commit description:
  
BUG= skia:5182 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166533002

Review-Url: https://codereview.chromium.org/2166533002
Commit  : 35f255f0f77dd0dea58d2f7aa07f6ec8b3994819
Date    : Tue Jul 19 19:59:35 2016


===== TESTED REVISIONS =====
Revision                         Mean     Std Dev   N  Good?
chromium@406390                  155.291  1.31555   8  good
chromium@406396                  154.135  2.31968   8  good
chromium@406399                  154.519  1.54096   5  good
chromium@406399,skia@35f255f0f7  147.093  0.477351  5  bad    <--
chromium@406399,skia@575b2a3bb9  148.111  0.970462  5  bad
chromium@406399,skia@4bcb4c7a25  148.657  1.94612   5  bad
chromium@406400                  147.663  1.82405   5  bad
chromium@406401                  148.233  2.24789   5  bad
chromium@406412                  151.573  1.38903   8  bad
chromium@406434                  150.412  3.80556   5  bad
chromium@406477                  145.0    2.04101   5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 631391

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout
Test Metric: auto-grid-lots-of-data/auto-grid-lots-of-data
Relative Change: 6.21%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/832
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006068156703232576


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5742770291998720

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 6 by mtklein@chromium.org, Jul 27 2016 

Suspicious.  I don't think the particular path altered in https://codereview.chromium.org/2166533002 is used by Chrome/Blink yet.

Comment 8 by primiano@chromium.org, Jul 27 2016 

Let me try another bisect, that metric is quite noisy (even though the bisect result in #5 seems pretty clean)
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jul 29 2016 

Bisect failed: Unknown
Failure reason: the build has failed due to infrastructure failure.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jul 29 2016 

Bisect failed: Unknown
Failure reason: the build has failed due to infrastructure failure.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Jul 29 2016

Cc: sashab@chromium.org
Owner: sashab@chromium.org

=== Auto-CCing suspected CL author sashab@chromium.org ===

Hi sashab@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Make CSSValuePair store const CSSValues
Author  : sashab
Commit description:
  
Make CSSValuePair store const CSSValues, which involves making the
constructor take and getter methods return const CSSValue*s. This is an
entirely mechanical change that is more semantically correct and safe,
and is pre-work for making CSSStyleValue::toCSSValue() return a const
CSSValue.

BUG=526586

Review-Url: https://codereview.chromium.org/2158723002
Cr-Commit-Position: refs/heads/master@{#406459}
Commit  : d479da5969016b6343a6515a827a22abb598862d
Date    : Wed Jul 20 02:09:50 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@406390  154.126  1.78868  5  good
chromium@406434  151.384  1.4669   5  good
chromium@406456  154.009  1.80104  5  good
chromium@406458  153.34   2.53263  5  good
chromium@406459  147.408  2.40774  5  bad    <--
chromium@406462  148.214  1.26909  5  bad
chromium@406467  145.761  2.69085  5  bad
chromium@406477  144.806  1.50905  5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 631391

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout
Test Metric: auto-grid-lots-of-data/auto-grid-lots-of-data
Relative Change: 6.05%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/847
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005805756592994880


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5825329789140992

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Jul 30 2016 


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@406390  95.1827  60.7245  12  good
chromium@406477  99.5357  55.0971  12  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 631391

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout
Test Metric: auto-grid-lots-of-data/auto-grid-lots-of-data
Relative Change: 174.84%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/843
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005837438824510880


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5799708027518976

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 16 by sullivan@chromium.org, Aug 5 2016

Status: WontFix (was: Assigned)
The regression recovered.
►

Sign in to add a comment