New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631332 link

Starred by 3 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary padding is seen after selecting initial options of side nav menu.

Reported by dmascare...@etouch.net, Jul 26 2016 
Chrome Version: 54.0.2808.0 (Official Build) 96ce8347f39ce0eebd10de476afb08c0afb406c9-refs/heads/master@{#407658}
OS: MAC (10.10.4,10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings
2. Click menu icon to open side nav menu and click on ‘People’ or ‘Appearance’ 
3. Scrolldown the page and observe.

Actual: Unnecessary padding/space is seen after step 3.
Expected: Padding should not be seen for initial options i.e should be seen after ‘Default browser'.

This is regression issue, broken in ‘M 54’ and will soon update the bisect info:

Good build:54.0.2807.0
Bad build:54.0.2808.0

Comment 1 by dmascare...@etouch.net, Jul 26 2016

Labels: hasbisect OS-Linux
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/8ea249f8b70f154f9995ed538fc853fe9cf46503..899319adcf7f9ba3e7e215c77a533622ccf5a419?pretty=fuller&n=1000

Suspecting: r407581

Note: Issue is reproducible on Linux OS and will soon update the Windows OS info.
Actual.mov
2.0 MB Download
Expected.mov
1.8 MB Download

Comment 2 by ligim...@chromium.org, Jul 26 2016

Labels: ReleaseBlock-Stable
Tagging with RBS , since its a regression in M54.

Comment 3 by ajha@chromium.org, Jul 29 2016 

Friendly ping to get an update on this issue from dschuyler@.

Comment 4 by dschuyler@chromium.org, Jul 29 2016 

The padding at the end of the page is a work in progress.
It is likely to be updated again next week.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4570d5e8b6094ee45234dcf1ef12f984dcd55d6f

commit 4570d5e8b6094ee45234dcf1ef12f984dcd55d6f
Author: dschuyler <dschuyler@chromium.org>
Date: Sat Jul 30 02:44:24 2016

[MD settings] only add overscroll if needed.

This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.

This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.

BUG= 631332 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2201553002
Cr-Commit-Position: refs/heads/master@{#408847}

[modify] https://crrev.com/4570d5e8b6094ee45234dcf1ef12f984dcd55d6f/chrome/browser/resources/settings/settings_main/settings_main.js

Comment 6 by dschuyler@chromium.org, Aug 1 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0608e39162e98e0e1d5e80bcb043899f4d513953

commit 0608e39162e98e0e1d5e80bcb043899f4d513953
Author: michaelpg <michaelpg@chromium.org>
Date: Mon Aug 01 19:29:29 2016

MD Settings: fix a couple errors

Fix an error when navigating Chrome to a section (e.g. chrome://md-settings/search).

Remove an observer that was removed.

BUG= 631332 
R=dschyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2197943002
Cr-Commit-Position: refs/heads/master@{#409024}

[modify] https://crrev.com/0608e39162e98e0e1d5e80bcb043899f4d513953/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/0608e39162e98e0e1d5e80bcb043899f4d513953/chrome/browser/resources/settings/settings_menu/settings_menu.js

Comment 8 by ashej...@chromium.org, Aug 2 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2816.0
Retested the above issue on - Mac 10.11.6 & Ubuntu 14.04  with chrome version - 54.0.2816.0 & and unnecessary padding is not seen on Md-settings page.

Hence marking the same as TE-Verified-54.0.2816.0.

Attach is the screen-cast.

Thank you!
Retest-631332.mp4
4.0 MB View Download
►

Sign in to add a comment