New issue
Advanced search Search tips

Issue 631325 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task
Launch-Accessibility: NotReviewed
Launch-Legal: NotReviewed
Launch-Privacy: NotReviewed
Launch-Security: NotReviewed
Launch-Test: NotReviewed
Launch-UI: NotReviewed

Blocking:
issue 6792



Sign in to add a comment

Align behavior of window.external.IsSearchProviderInstalled and window.external.AddSearchProvider with the spec

Project Member Reported by dcheng@chromium.org, Jul 26 2016

Issue description

Change description:
window.external.IsSearchProviderInstalled and window.external.AddSearchProvider will both be defined as methods that are no-ops.

Changes to API surface:
- Add back AddSearchProvider (removed in  issue 542487 ), with a no-op implementation.
- Change IsSearchProvider() to be a no-op implementation as well.

Links:
Public standards discussion: https://github.com/whatwg/html/issues/713

Support in other browsers:
Internet Explorer: No-ops in IE10, though the documentation notes that AddSearchProvider [1] always returns S_OK in IE10 and IsSearchProviderInstalled [2] always returns 2 in IE10.
Firefox: Firefox 2+, though the documentation notes that this feature may be removed at any time [3].
Safari: none

[1] https://msdn.microsoft.com/en-us/library/aa744112(v=vs.85).aspx
[2] https://msdn.microsoft.com/en-us/library/aa342526(v=vs.85).aspx
[3] https://developer.mozilla.org/en-US/docs/Web/API/Window/sidebar/Adding_search_engines_from_Web_pages
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0

commit c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0
Author: dcheng <dcheng@chromium.org>
Date: Thu Jul 28 01:23:42 2016

Move SearchProvider implementation into Blink and make it a no-op.

BUG= 545585 , 631325 

Review-Url: https://codereview.chromium.org/2177123003
Cr-Commit-Position: refs/heads/master@{#408307}

[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/browser/BUILD.gn
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/browser/chrome_content_browser_client.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/browser/external_extension_browsertest.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/browser/search_engines/search_provider_install_data.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/browser/search_engines/search_provider_install_data.h
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/browser/search_engines/search_provider_install_data_unittest.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/browser/search_engines/search_provider_install_state_impl.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/browser/search_engines/search_provider_install_state_impl.h
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/browser/ui/search_engines/search_engine_tab_helper.h
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/chrome_browser.gypi
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/chrome_common.gypi
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/chrome_renderer.gypi
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/chrome_tests.gypi
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/common/BUILD.gn
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/common/render_messages.h
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/common/search_provider.h
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/common/search_provider.mojom
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/renderer/BUILD.gn
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/chrome/renderer/chrome_content_renderer_client.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/renderer/external_extension.cc
[delete] https://crrev.com/e2ed68b3eab03e6fb5f0035a10022493a44caf05/chrome/renderer/external_extension.h
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/window-properties-expected.txt
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/Source/core/frame/DOMWindow.h
[add] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/Source/core/frame/External.h
[add] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/Source/core/frame/External.idl
[modify] https://crrev.com/c4fc2c3302b82b57d9a4dfcef4d9c8e292f710d0/third_party/WebKit/Source/core/frame/Window.idl

Comment 2 by dcheng@chromium.org, Jul 28 2016

Labels: Launch-Status-Approval-Requested
Status: Started (was: Assigned)
(I have no idea how this works, so hopefully I'm setting the right flags?)

Comment 3 by groby@chromium.org, Aug 30 2016

Blocking: 6792
When this launches, I assume that "magically" fixes  bug #6792 , right? ("Better feedback  when AddSearchProvider fails")

Comment 4 by hayato@chromium.org, Aug 28 2017

Components: -Blink>DOM Blink>HTML

Comment 5 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge

Comment 6 by dcheng@chromium.org, Mar 15 2018

Status: Fixed (was: Started)

Sign in to add a comment