New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631322 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

InterstitialPageImpTests are failing under TSan

Project Member Reported by benwells@chromium.org, Jul 26 2016

Issue description

It seems like a recent change to the IPC / Mojo implementation has uncovered a race in this test. See  issue 631311  for more details.

mohsen, you seem to be the creator of this test so giving this one to you.
 
Labels: Stability-ThreadSanitizer
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e

commit d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e
Author: benwells <benwells@chromium.org>
Date: Tue Jul 26 07:16:34 2016

Disable some tests with errors under TSan

TBR=kinuko, clamy
BUG= 631322 ,  631323 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2179353002
Cr-Commit-Position: refs/heads/master@{#407730}

[modify] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/content/browser/frame_host/interstitial_page_impl_browsertest.cc
[modify] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/content/browser/service_worker/service_worker_browsertest.cc

Owner: slangley@chromium.org
Status: Started (was: Untriaged)
Mojofication of clipboard will fix this, I guess.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e830001af5df676765a3cf3567053e4eb342c232

commit e830001af5df676765a3cf3567053e4eb342c232
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Nov 24 01:16:18 2017

Convert clipboard_messages from IPC to Mojo.

Convert all of the IPC messages in content/common/clipboard_messages.h
to Mojo. This CL includes a number of changes as a result:

- Remove the Dispatch of messages for OS_WIN on the IO thread. The requirement
  to do this seems to be inspired by deadlocks with NPAPI plugins, but as
  NPAPI is now persona non grata we can remove this and all the code that
  existed to support it.
- interstitial page test was inserting a message_filter to intercept write calls
  to the clipboard - replace this with a ClipboardObserver and have the
  test_clipboard fire the event for observation. This also caused TSAN failures,
  so we can re-enable the cut test under TSAN now.
- Remove the clipboard delegate entirely, and move some logic to write
  images to shared memory for transport to the impl file now.

Bug:  775830 ,  631322 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I35c6238a41190b3bc82e0cfab7bbfe4325a3be21
Reviewed-on: https://chromium-review.googlesource.com/752861
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519040}
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/BUILD.gn
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/frame_host/interstitial_page_impl_browsertest.cc
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl.cc
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl.h
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl_mac.mm
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl_unittest.cc
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter.cc
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter.h
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter_mac.mm
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter_unittest.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/BUILD.gn
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/clipboard.mojom
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/clipboard.typemap
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/common/clipboard_messages.h
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/clipboard_struct_traits.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/content_message_generator.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/typemaps.gni
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/public/test/browser_test_utils.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/BUILD.gn
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/renderer_blink_platform_impl.h
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/renderer/renderer_clipboard_delegate.cc
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/renderer/renderer_clipboard_delegate.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/webclipboard_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/webclipboard_impl.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/test/BUILD.gn
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/BUILD.gn
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/OWNERS
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/clipboard.mojom
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/clipboard.typemap
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/clipboard_struct_traits.h
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/typemaps.gni
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/test/test_clipboard.cc

Status: Fixed (was: Started)

Sign in to add a comment