New issue
Advanced search Search tips

Issue 631315 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

GYP error on DrMemory after v8 roll

Project Member Reported by benwells@chromium.org, Jul 26 2016

Issue description

Revert of roll failed, so unrolling manually.
 
See https://codereview.chromium.org/2182763003/ (the failed revert) for more details.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feb65014ca1410c71cc86e4f10c31d8c2edd8b59

commit feb65014ca1410c71cc86e4f10c31d8c2edd8b59
Author: benwells <benwells@chromium.org>
Date: Tue Jul 26 06:32:26 2016

Revert v8 roll as it caused DrMemory GYP errors.

TBR=machenbach
BUG= 631315 

Review-Url: https://codereview.chromium.org/2185473002
Cr-Commit-Position: refs/heads/master@{#407724}

[modify] https://crrev.com/feb65014ca1410c71cc86e4f10c31d8c2edd8b59/DEPS

Status: Assigned (was: Unconfirmed)
Will revert CL on v8 side and reissue a cherry-picked roll.

This seems to have slipped through undetected as there is no gyp support anymore in the chromium CQ that would have exercised the erroneous parts.

Do the drmemory bots switch to GN soon? That would be desirable if failures there can cause roll reverts.
Yeah, gyp toolchains aren't exercised as much as they used to be. It would be good to switch over those bots but I'm not sure who is working on it.
Cc: dpranke@chromium.org
CC dirk regarding comment 4.
Roll with the revert https://codereview.chromium.org/2180123002/
Mergedinto: 631310
Status: Duplicate (was: Assigned)
There isn't much GYP coverage left, but there is still a win GYP builder in the Chromium CQ (win8_chromium_gyp_rel), which succeeded on the roll.

However, most of the GYP builders do not run with the syntax check option, so they miss errors like this.

We're trying to stamp out the last win GYP builders this week; the DrMem builders will hopefully be flipped over today, and we'll hopefully try to flip the official builders again today or tomorrow (we've been blocked on a bug but hopefully that fix is rolling in now). 
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27 2016

Labels: merge-merged-2808
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194ee6e28fc2f451e2de22380dee2b4ea09259e2

commit 194ee6e28fc2f451e2de22380dee2b4ea09259e2
Author: Will Harris <wfh@chromium.org>
Date: Wed Jul 27 01:58:43 2016

Merge 2808: Revert v8 roll as it caused DrMemory GYP errors.

TBR=machenbach
BUG= 631315 ,631310

Review-Url: https://codereview.chromium.org/2185473002
Cr-Commit-Position: refs/heads/master@{#407724}
(cherry picked from commit feb65014ca1410c71cc86e4f10c31d8c2edd8b59)

Review URL: https://codereview.chromium.org/2178353007 .

Cr-Commit-Position: refs/branch-heads/2808@{#2}
Cr-Branched-From: 96ce8347f39ce0eebd10de476afb08c0afb406c9-refs/heads/master@{#407658}

[modify] https://crrev.com/194ee6e28fc2f451e2de22380dee2b4ea09259e2/DEPS

Sign in to add a comment